diff mbox series

[5/5] dt-bindings: clock: Introduce pdc bindings for SDX65

Message ID 20210709200339.17638-6-quic_vamslank@quicinc.com
State Superseded
Headers show
Series Add Pdc, GCC and RPMh clock support for SDX65 | expand

Commit Message

Vamsi Krishna Lanka July 9, 2021, 8:03 p.m. UTC 
From: Vamsi krishna Lanka <quic_vamslank@quicinc.com>

Add compatible for SDX65 pdc.

Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
---
 .../devicetree/bindings/interrupt-controller/qcom,pdc.txt        | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjorn Andersson July 10, 2021, 3:31 a.m. UTC | #1 
On Fri 09 Jul 15:03 CDT 2021, quic_vamslank@quicinc.com wrote:

> From: Vamsi krishna Lanka <quic_vamslank@quicinc.com>
> 
> Add compatible for SDX65 pdc.
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

That said, this patch is independent from the clock patches and would be
picked up by a different maintainer than the clock patches, so including
it in the same series only risk complicating the pickup of the patch.

And with that in mind, looking at the recipients of all your patches you
forgot toadd Stephen to the clock patches, Linus is not involved in
the clock patches and you completely missed the irq maintainer.

Please use scripts/get_maintainer.pl to list the appropriate recipients
for each patch(series), to ensure that your patches will get the
attention they deserve.

Thanks,
Bjorn

> Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
> ---
>  .../devicetree/bindings/interrupt-controller/qcom,pdc.txt        | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> index e9afb48182c7..7bdbffb572dc 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> @@ -22,6 +22,7 @@ Properties:
>  		    - "qcom,sdm845-pdc": For SDM845
>  		    - "qcom,sdm8250-pdc": For SM8250
>  		    - "qcom,sdm8350-pdc": For SM8350
> +		    - "qcom,sdx65-pdc": For SDX65
>  
>  - reg:
>  	Usage: required
> -- 
> 2.32.0
>
Vamsi Krishna Lanka July 15, 2021, 6:31 p.m. UTC | #2 
On Fri, Jul 09, 2021 at 10:31:03PM -0500, Bjorn Andersson wrote:
> On Fri 09 Jul 15:03 CDT 2021, quic_vamslank@quicinc.com wrote:

> 

> > From: Vamsi krishna Lanka <quic_vamslank@quicinc.com>

> > 

> > Add compatible for SDX65 pdc.

> > 

> 

> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> 

> That said, this patch is independent from the clock patches and would be

> picked up by a different maintainer than the clock patches, so including

> it in the same series only risk complicating the pickup of the patch.

> 

> And with that in mind, looking at the recipients of all your patches you

> forgot toadd Stephen to the clock patches, Linus is not involved in

> the clock patches and you completely missed the irq maintainer.

> 

> Please use scripts/get_maintainer.pl to list the appropriate recipients

> for each patch(series), to ensure that your patches will get the

> attention they deserve.


Thanks for the review comments Bjorn. I'll run get_maintainer.pl like you
suggested.

Thanks,
Vamsi
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
index e9afb48182c7..7bdbffb572dc 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
@@ -22,6 +22,7 @@  Properties:
 		    - "qcom,sdm845-pdc": For SDM845
 		    - "qcom,sdm8250-pdc": For SM8250
 		    - "qcom,sdm8350-pdc": For SM8350
+		    - "qcom,sdx65-pdc": For SDX65
 
 - reg:
 	Usage: required