diff mbox series

[v6,9/9] gpio: gpio-aspeed-sgpio: Return error if ngpios is not multiple of 8.

Message ID 20210712100317.23298-10-steven_lee@aspeedtech.com
State Accepted
Commit f43837f4f63b1a58084d7147b8b34c0f3dd261f6
Headers show
Series [v6,1/9] dt-bindings: aspeed-sgpio: Convert txt bindings to yaml. | expand

Commit Message

Steven Lee July 12, 2021, 10:03 a.m. UTC 
Add an else-if condition in the probe function to check whether ngpios is
multiple of 8.
Per AST datasheet, numbers of available serial GPIO pins in Serial GPIO
Configuration Register must be n bytes. For instance, if n = 1, it means
AST SoC supports 8 GPIO pins.

Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
---
 drivers/gpio/gpio-aspeed-sgpio.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Linus Walleij July 23, 2021, 10 a.m. UTC | #1 
On Mon, Jul 12, 2021 at 12:04 PM Steven Lee <steven_lee@aspeedtech.com> wrote:

> Add an else-if condition in the probe function to check whether ngpios is

> multiple of 8.

> Per AST datasheet, numbers of available serial GPIO pins in Serial GPIO

> Configuration Register must be n bytes. For instance, if n = 1, it means

> AST SoC supports 8 GPIO pins.

>

> Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>

> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>


Reviewed-by: Linus Walleij <linus.walleij@linaro.org>


Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-aspeed-sgpio.c b/drivers/gpio/gpio-aspeed-sgpio.c
index b3d05fc724f0..191b82a2560c 100644
--- a/drivers/gpio/gpio-aspeed-sgpio.c
+++ b/drivers/gpio/gpio-aspeed-sgpio.c
@@ -537,6 +537,10 @@  static int __init aspeed_sgpio_probe(struct platform_device *pdev)
 	if (rc < 0) {
 		dev_err(&pdev->dev, "Could not read ngpios property\n");
 		return -EINVAL;
+	} else if (nr_gpios % 8) {
+		dev_err(&pdev->dev, "Number of GPIOs not multiple of 8: %d\n",
+			nr_gpios);
+		return -EINVAL;
 	}
 
 	rc = device_property_read_u32(&pdev->dev, "bus-frequency", &sgpio_freq);