| Message ID | 7091e8213602be64826fd689a7337246d218f3b1.1626255421.git.geert+renesas@glider.be |
|---|---|
| State | Accepted |
| Commit | 3e204d6b76b29274cc8e57f8bd8d9873f04a7f48 |
| Headers | show |
| Series | [resend] Input: adc-keys - drop bogus __refdata annotation | expand |
On 14/07/2021 11:38:33+0200, Geert Uytterhoeven wrote: > As the ADC ladder input driver does not have any code or data located in > initmem, there is no need to annotate the adc_keys_driver structure with > __refdata. Drop the annotation, to avoid suppressing future section > warnings. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> I must admit I can't remember why I used that annotation... > --- > drivers/input/keyboard/adc-keys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/adc-keys.c b/drivers/input/keyboard/adc-keys.c > index 6d5be48d1b3d7988..bf72ab8df817756f 100644 > --- a/drivers/input/keyboard/adc-keys.c > +++ b/drivers/input/keyboard/adc-keys.c > @@ -193,7 +193,7 @@ static const struct of_device_id adc_keys_of_match[] = { > MODULE_DEVICE_TABLE(of, adc_keys_of_match); > #endif > > -static struct platform_driver __refdata adc_keys_driver = { > +static struct platform_driver adc_keys_driver = { > .driver = { > .name = "adc_keys", > .of_match_table = of_match_ptr(adc_keys_of_match), > -- > 2.25.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On Wed, Jul 14, 2021 at 11:38:33AM +0200, Geert Uytterhoeven wrote: > As the ADC ladder input driver does not have any code or data located in > initmem, there is no need to annotate the adc_keys_driver structure with > __refdata. Drop the annotation, to avoid suppressing future section > warnings. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied, thank you. -- Dmitry
diff --git a/drivers/input/keyboard/adc-keys.c b/drivers/input/keyboard/adc-keys.c index 6d5be48d1b3d7988..bf72ab8df817756f 100644 --- a/drivers/input/keyboard/adc-keys.c +++ b/drivers/input/keyboard/adc-keys.c @@ -193,7 +193,7 @@ static const struct of_device_id adc_keys_of_match[] = { MODULE_DEVICE_TABLE(of, adc_keys_of_match); #endif -static struct platform_driver __refdata adc_keys_driver = { +static struct platform_driver adc_keys_driver = { .driver = { .name = "adc_keys", .of_match_table = of_match_ptr(adc_keys_of_match),
As the ADC ladder input driver does not have any code or data located in initmem, there is no need to annotate the adc_keys_driver structure with __refdata. Drop the annotation, to avoid suppressing future section warnings. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/input/keyboard/adc-keys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)