| Message ID | 1626316157-24935-4-git-send-email-kewei.xu@mediatek.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/8] dt-bindings: i2c: update bindings for MT8195 SoC | expand |
Hi, On Thu, Jul 15, 2021 at 10:31 AM Kewei Xu <kewei.xu@mediatek.com> wrote: > > The reason for the modification here is that the previous > offset information is incorrect, OFFSET_DEBUGSTAT = 0xE4 is > the correct value. > > Signed-off-by: Kewei Xu <kewei.xu@mediatek.com> This needs a fixes tag: Fixes: 25708278f810 ("i2c: mediatek: Add i2c support for MediaTek MT8183") Otherwise, Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
On Thu, 2021-07-15 at 13:23 +0800, Chen-Yu Tsai wrote: > Hi, > > On Thu, Jul 15, 2021 at 10:31 AM Kewei Xu <kewei.xu@mediatek.com> wrote: > > > > The reason for the modification here is that the previous > > offset information is incorrect, OFFSET_DEBUGSTAT = 0xE4 is > > the correct value. > > > > Signed-off-by: Kewei Xu <kewei.xu@mediatek.com> > > This needs a fixes tag: > > Fixes: 25708278f810 ("i2c: mediatek: Add i2c support for MediaTek MT8183") > > Otherwise, > > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> Hi Chen-Yu, OK, I will resubmit a patch to add a fixes tag. thanks Kewei
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c index 64acd96..e65a41e 100644 --- a/drivers/i2c/busses/i2c-mt65xx.c +++ b/drivers/i2c/busses/i2c-mt65xx.c @@ -195,7 +195,7 @@ enum I2C_REGS_OFFSET { [OFFSET_SOFTRESET] = 0x50, [OFFSET_MULTI_DMA] = 0x84, [OFFSET_SCL_MIS_COMP_POINT] = 0x90, - [OFFSET_DEBUGSTAT] = 0xe0, + [OFFSET_DEBUGSTAT] = 0xe4, [OFFSET_DEBUGCTRL] = 0xe8, [OFFSET_FIFO_STAT] = 0xf4, [OFFSET_FIFO_THRESH] = 0xf8,
The reason for the modification here is that the previous offset information is incorrect, OFFSET_DEBUGSTAT = 0xE4 is the correct value. Signed-off-by: Kewei Xu <kewei.xu@mediatek.com> --- drivers/i2c/busses/i2c-mt65xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)