diff mbox series

[v4,5/8] dt-bindings: i2c: add attribute default-timing-adjust

Message ID 1626517079-9057-6-git-send-email-kewei.xu@mediatek.com
State New
Headers show
Series Introduce an attribute to choose timing setting | expand

Commit Message

Kewei Xu July 17, 2021, 10:17 a.m. UTC
Add attribute default-timing-adjust for DT-binding document.

Fixes: be5ce0e97cc7 ("i2c: mediatek: Add i2c ac-timing adjust support")
Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
---
 Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring July 22, 2021, 3:10 a.m. UTC | #1
On Sat, Jul 17, 2021 at 06:17:56PM +0800, Kewei Xu wrote:
> Add attribute default-timing-adjust for DT-binding document.

> 

> Fixes: be5ce0e97cc7 ("i2c: mediatek: Add i2c ac-timing adjust support")

> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>

> ---

>  Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt

> index 7c4915bc4439..7b80a11d4d4c 100644

> --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt

> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt

> @@ -33,6 +33,8 @@ Optional properties:

>    - mediatek,have-pmic: platform can control i2c form special pmic side.

>      Only mt6589 and mt8135 support this feature.

>    - mediatek,use-push-pull: IO config use push-pull mode.

> +  - mediatek,default-timing-adjust: use default timing calculation, no timing

> +    adjustment.


'mediatek,use-default-timing' perhaps as it means don't adjust anything.

>  

>  Example:

>  

> -- 

> 2.18.0

> 

>
Kewei Xu Aug. 18, 2021, 6:37 a.m. UTC | #2
On Wed, 2021-07-21 at 21:10 -0600, Rob Herring wrote:
> On Sat, Jul 17, 2021 at 06:17:56PM +0800, Kewei Xu wrote:

> > Add attribute default-timing-adjust for DT-binding document.

> > 

> > Fixes: be5ce0e97cc7 ("i2c: mediatek: Add i2c ac-timing adjust

> > support")

> > Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>

> > ---

> >  Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 2 ++

> >  1 file changed, 2 insertions(+)

> > 

> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt

> > b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt

> > index 7c4915bc4439..7b80a11d4d4c 100644

> > --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt

> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt

> > @@ -33,6 +33,8 @@ Optional properties:

> >    - mediatek,have-pmic: platform can control i2c form special pmic

> > side.

> >      Only mt6589 and mt8135 support this feature.

> >    - mediatek,use-push-pull: IO config use push-pull mode.

> > +  - mediatek,default-timing-adjust: use default timing

> > calculation, no timing

> > +    adjustment.

> 

> 'mediatek,use-default-timing' perhaps as it means don't adjust

> anything.

> 

> >  

> >  Example:

> >  

> > -- 

> > 2.18.0

> > 

Hi Rob,

Thanks for your suggestion. We will use "mediatek,use-default-timing"
instead of "mediatek,default-timing-adjust" in the next version of
patch.

Thanks
kewei
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
index 7c4915bc4439..7b80a11d4d4c 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
@@ -33,6 +33,8 @@  Optional properties:
   - mediatek,have-pmic: platform can control i2c form special pmic side.
     Only mt6589 and mt8135 support this feature.
   - mediatek,use-push-pull: IO config use push-pull mode.
+  - mediatek,default-timing-adjust: use default timing calculation, no timing
+    adjustment.
 
 Example: