diff mbox series

HID: apple: Add support for Keychron K1 wireless keyboard

Message ID 20210717170431.i6cubjpihjdxepmu@kotori.hexchain.org
State Accepted
Commit ebe0b42a4252333aa4af60fd4d11b69405aa6068
Headers show
Series HID: apple: Add support for Keychron K1 wireless keyboard | expand

Commit Message

Haochen Tong July 17, 2021, 5:04 p.m. UTC
The Keychron K1 wireless keyboard has a set of Apple-like function keys
and an Fn key that works like on an Apple bluetooth keyboard. It
identifies as an Apple Alu RevB ANSI keyboard (05ac:024f) over USB and
BT. Use hid-apple for it so the Fn key and function keys work correctly.

Signed-off-by: Haochen Tong <i@hexchain.org>
---
 drivers/hid/hid-apple.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jiri Kosina July 28, 2021, 9:41 a.m. UTC | #1
On Sun, 18 Jul 2021, Haochen Tong wrote:

> The Keychron K1 wireless keyboard has a set of Apple-like function keys

> and an Fn key that works like on an Apple bluetooth keyboard. It

> identifies as an Apple Alu RevB ANSI keyboard (05ac:024f) over USB and

> BT. Use hid-apple for it so the Fn key and function keys work correctly.

> 

> Signed-off-by: Haochen Tong <i@hexchain.org>

> ---

>  drivers/hid/hid-apple.c | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c

> index 6b8f0d004d34..dc6bd4299c54 100644

> --- a/drivers/hid/hid-apple.c

> +++ b/drivers/hid/hid-apple.c

> @@ -501,6 +501,8 @@ static const struct hid_device_id apple_devices[] = {

>  			APPLE_RDESC_JIS },

>  	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_REVB_ANSI),

>  		.driver_data = APPLE_HAS_FN },

> +	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_REVB_ANSI),

> +		.driver_data = APPLE_HAS_FN },

>  	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_REVB_ISO),

>  		.driver_data = APPLE_HAS_FN },

>  	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_REVB_ISO),


Applied, thank you.

-- 
Jiri Kosina
SUSE Labs
diff mbox series

Patch

diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index 6b8f0d004d34..dc6bd4299c54 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -501,6 +501,8 @@  static const struct hid_device_id apple_devices[] = {
 			APPLE_RDESC_JIS },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_REVB_ANSI),
 		.driver_data = APPLE_HAS_FN },
+	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_REVB_ANSI),
+		.driver_data = APPLE_HAS_FN },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_REVB_ISO),
 		.driver_data = APPLE_HAS_FN },
 	{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_REVB_ISO),