diff mbox series

[1/2] soundwire: dmi-quirks: add quirk for Intel 'Bishop County' NUC M15

Message ID 20210719233248.557923-2-pierre-louis.bossart@linux.intel.com
State Accepted
Commit caa15c8dcb00f9dfe9f304e6e0955c5b29cf2499
Headers show
Series ASoC/soundwire: add quirks for Intel 'Bishop County' NUC M15 | expand

Commit Message

Pierre-Louis Bossart July 19, 2021, 11:32 p.m. UTC 
The same quirk is used for LAPBC510 and LAPBC710 skews who use the
same audio design.

These devices have the same BIOS issues inherited from the Intel
reference, add the same _ADR remap previously used on HP devices.

BugLink: https://github.com/thesofproject/linux/issues/3049
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <bard.liao@intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
---
 drivers/soundwire/dmi-quirks.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

Comments

Vinod Koul July 22, 2021, 2:02 p.m. UTC | #1 
On 19-07-21, 18:32, Pierre-Louis Bossart wrote:
> The same quirk is used for LAPBC510 and LAPBC710 skews who use the
> same audio design.
> 
> These devices have the same BIOS issues inherited from the Intel
> reference, add the same _ADR remap previously used on HP devices.

This fails to apply on rc1, pls rebase or if there are any dependencies,
do spell them out
Pierre-Louis Bossart July 22, 2021, 2:25 p.m. UTC | #2 
On 7/22/21 9:02 AM, Vinod Koul wrote:
> On 19-07-21, 18:32, Pierre-Louis Bossart wrote:
>> The same quirk is used for LAPBC510 and LAPBC710 skews who use the
>> same audio design.
>>
>> These devices have the same BIOS issues inherited from the Intel
>> reference, add the same _ADR remap previously used on HP devices.
> 
> This fails to apply on rc1, pls rebase or if there are any dependencies,
> do spell them out

it likely depends on

[PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values

which was sent by Bard when the merge window opened.
Pierre-Louis Bossart July 22, 2021, 2:29 p.m. UTC | #3 
On 7/22/21 9:25 AM, Pierre-Louis Bossart wrote:
> 
> 
> On 7/22/21 9:02 AM, Vinod Koul wrote:
>> On 19-07-21, 18:32, Pierre-Louis Bossart wrote:
>>> The same quirk is used for LAPBC510 and LAPBC710 skews who use the
>>> same audio design.
>>>
>>> These devices have the same BIOS issues inherited from the Intel
>>> reference, add the same _ADR remap previously used on HP devices.
>>
>> This fails to apply on rc1, pls rebase or if there are any dependencies,
>> do spell them out
> 
> it likely depends on
> 
> [PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values
> 
> which was sent by Bard when the merge window opened.

And you've just applied that dependency, do you mind retrying Vinod?
Vinod Koul July 23, 2021, 6:06 a.m. UTC | #4 
On 22-07-21, 09:25, Pierre-Louis Bossart wrote:
> 
> 
> On 7/22/21 9:02 AM, Vinod Koul wrote:
> > On 19-07-21, 18:32, Pierre-Louis Bossart wrote:
> >> The same quirk is used for LAPBC510 and LAPBC710 skews who use the
> >> same audio design.
> >>
> >> These devices have the same BIOS issues inherited from the Intel
> >> reference, add the same _ADR remap previously used on HP devices.
> > 
> > This fails to apply on rc1, pls rebase or if there are any dependencies,
> > do spell them out
> 
> it likely depends on
> 
> [PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values

As I said above, if there is a dependency, pls spell it out!

> which was sent by Bard when the merge window opened.
Vinod Koul July 23, 2021, 6:07 a.m. UTC | #5 
On 22-07-21, 09:29, Pierre-Louis Bossart wrote:
> 
> 
> On 7/22/21 9:25 AM, Pierre-Louis Bossart wrote:
> > 
> > 
> > On 7/22/21 9:02 AM, Vinod Koul wrote:
> >> On 19-07-21, 18:32, Pierre-Louis Bossart wrote:
> >>> The same quirk is used for LAPBC510 and LAPBC710 skews who use the
> >>> same audio design.
> >>>
> >>> These devices have the same BIOS issues inherited from the Intel
> >>> reference, add the same _ADR remap previously used on HP devices.
> >>
> >> This fails to apply on rc1, pls rebase or if there are any dependencies,
> >> do spell them out
> > 
> > it likely depends on
> > 
> > [PATCH] soundwire: dmi-quirks: add ull suffix for SoundWire _ADR values
> > 
> > which was sent by Bard when the merge window opened.
> 
> And you've just applied that dependency, do you mind retrying Vinod?

Yes it applies now...
diff mbox series

Patch

diff --git a/drivers/soundwire/dmi-quirks.c b/drivers/soundwire/dmi-quirks.c
index 1ac16687e315..0ca2a3e3a02e 100644
--- a/drivers/soundwire/dmi-quirks.c
+++ b/drivers/soundwire/dmi-quirks.c
@@ -16,11 +16,11 @@  struct adr_remap {
 };
 
 /*
- * HP Spectre 360 Convertible devices do not expose the correct _ADR
- * in the DSDT.
+ * Some TigerLake devices based on an initial Intel BIOS do not expose
+ * the correct _ADR in the DSDT.
  * Remap the bad _ADR values to the ones reported by hardware
  */
-static const struct adr_remap hp_spectre_360[] = {
+static const struct adr_remap intel_tgl_bios[] = {
 	{
 		0x000010025D070100ull,
 		0x000020025D071100ull
@@ -61,7 +61,15 @@  static const struct dmi_system_id adr_remap_quirk_table[] = {
 			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x360 Convertible"),
 		},
-		.driver_data = (void *)hp_spectre_360,
+		.driver_data = (void *)intel_tgl_bios,
+	},
+	{
+		/* quirk used for NUC15 'Bishop County' LAPBC510 and LAPBC710 skews */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Intel(R) Client Systems"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "LAPBC"),
+		},
+		.driver_data = (void *)intel_tgl_bios,
 	},
 	{
 		.matches = {