diff mbox series

scsi: lpfc: remove redundant assignment to pointer pcmd

Message ID 20210721095350.41564-1-colin.king@canonical.com
State New
Headers show
Series scsi: lpfc: remove redundant assignment to pointer pcmd | expand

Commit Message

Colin King July 21, 2021, 9:53 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The pointer pcmd is being initialized with a value that is never
read, the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/lpfc/lpfc_sli.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Martin K. Petersen July 27, 2021, 3:05 a.m. UTC | #1 
Colin,

> The pointer pcmd is being initialized with a value that is never read,

> the assignment is redundant and can be removed.


Applied to 5.15/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Martin K. Petersen July 29, 2021, 3:38 a.m. UTC | #2 
On Wed, 21 Jul 2021 10:53:50 +0100, Colin King wrote:

> The pointer pcmd is being initialized with a value that is never

> read, the assignment is redundant and can be removed.


Applied to 5.15/scsi-queue, thanks!

[1/1] scsi: lpfc: remove redundant assignment to pointer pcmd
      https://git.kernel.org/mkp/scsi/c/ff2d86d04d26

-- 
Martin K. Petersen	Oracle Linux Engineering
diff mbox series

Patch

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index c34240819d92..47dd13719901 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -10129,8 +10129,6 @@  lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq,
 		bf_set(wqe_ebde_cnt, &wqe->xmit_els_rsp.wqe_com, 0);
 		bf_set(wqe_rsp_temp_rpi, &wqe->xmit_els_rsp,
 		       phba->sli4_hba.rpi_ids[ndlp->nlp_rpi]);
-		pcmd = (uint32_t *) (((struct lpfc_dmabuf *)
-					iocbq->context2)->virt);
 		if (phba->fc_topology == LPFC_TOPOLOGY_LOOP) {
 				bf_set(els_rsp64_sp, &wqe->xmit_els_rsp, 1);
 				bf_set(els_rsp64_sid, &wqe->xmit_els_rsp,