diff mbox series

[2/5] arm64: dts: ls1088a: add missing PMU node

Message ID 20210722042450.11862-3-matt@traverse.com.au
State Superseded
Headers show
Series Add Traverse Technologies Ten64 board DTS | expand

Commit Message

Mathew McBride July 22, 2021, 4:24 a.m. UTC
The Performance Manager Unit was not described in the DTS
which meant performance event monitoring was not possible.

This was exposed by a change to the PMU handling in KVM
in 5.11-rc3 which now prevents a PMU being exposed to a
guest when the host does not provide one:
"KVM: arm64: Don't access PMCR_EL0 when no PMU is available"

Signed-off-by: Mathew McBride <matt@traverse.com.au>

---
 arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.30.1

Comments

Shawn Guo July 23, 2021, 8:36 a.m. UTC | #1
On Thu, Jul 22, 2021 at 04:24:47AM +0000, Mathew McBride wrote:
> The Performance Manager Unit was not described in the DTS

> which meant performance event monitoring was not possible.

> 

> This was exposed by a change to the PMU handling in KVM

> in 5.11-rc3 which now prevents a PMU being exposed to a

> guest when the host does not provide one:

> "KVM: arm64: Don't access PMCR_EL0 when no PMU is available"

> 

> Signed-off-by: Mathew McBride <matt@traverse.com.au>

> ---

>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 +++++

>  1 file changed, 5 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi

> index 79ceadc9dc4a..752c7f41e6b1 100644

> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi

> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi

> @@ -189,6 +189,11 @@ timer {

>  			     <1 10 IRQ_TYPE_LEVEL_LOW>;/* Hypervisor PPI */

>  	};

>  

> +	pmu {

> +		compatible = "arm,armv8-pmuv3";

> +		interrupts = <1 7 0x8>; /* PMU PPI, Level low type */


Use define GIC_PPI and IRQ_TYPE_LEVEL_LOW, so that you can drop the
comment.

Shawn

> +	};

> +

>  	psci {

>  		compatible = "arm,psci-0.2";

>  		method = "smc";

> -- 

> 2.30.1

>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index 79ceadc9dc4a..752c7f41e6b1 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -189,6 +189,11 @@  timer {
 			     <1 10 IRQ_TYPE_LEVEL_LOW>;/* Hypervisor PPI */
 	};
 
+	pmu {
+		compatible = "arm,armv8-pmuv3";
+		interrupts = <1 7 0x8>; /* PMU PPI, Level low type */
+	};
+
 	psci {
 		compatible = "arm,psci-0.2";
 		method = "smc";