| Message ID | 20210722115141.516-1-jslaby@suse.cz |
|---|---|
| State | Accepted |
| Commit | 0e9ffdb236b8d273a086e86887192a62dd8f144a |
| Headers | show |
| Series | [1/2] cx20442: tty_ldisc_ops::write_wakeup is optional | expand |
On Thu, Jul 22, 2021 at 01:51:40PM +0200, Jiri Slaby wrote: > TTY layer does nothing if tty_ldisc_ops::write_wakeup is NULL, so there > is no need to implement an empty one in cx20442. Drop it. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
diff --git a/sound/soc/codecs/cx20442.c b/sound/soc/codecs/cx20442.c index ec8d6e74b467..65c6b92d7b5f 100644 --- a/sound/soc/codecs/cx20442.c +++ b/sound/soc/codecs/cx20442.c @@ -279,11 +279,6 @@ static void v253_receive(struct tty_struct *tty, const unsigned char *cp, } } -/* Line discipline .write_wakeup() */ -static void v253_wakeup(struct tty_struct *tty) -{ -} - struct tty_ldisc_ops v253_ops = { .name = "cx20442", .owner = THIS_MODULE, @@ -291,7 +286,6 @@ struct tty_ldisc_ops v253_ops = { .close = v253_close, .hangup = v253_hangup, .receive_buf = v253_receive, - .write_wakeup = v253_wakeup, }; EXPORT_SYMBOL_GPL(v253_ops);
TTY layer does nothing if tty_ldisc_ops::write_wakeup is NULL, so there is no need to implement an empty one in cx20442. Drop it. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Cc: alsa-devel@alsa-project.org --- sound/soc/codecs/cx20442.c | 6 ------ 1 file changed, 6 deletions(-)