| Message ID | 20210722163832.22971-1-kabel@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [4.19] net: dsa: mv88e6xxx: use correct .stats_set_histogram() on Topaz | expand |
On Thu, Jul 22, 2021 at 06:38:32PM +0200, Marek Behún wrote: > commit 11527f3c4725640e6c40a2b7654e303f45e82a6c upstream. > > Commit 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") > introduced wrong .stats_set_histogram() method for Topaz family. > > The Peridot method should be used instead. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: David S. Miller <davem@davemloft.net> > --- > drivers/net/dsa/mv88e6xxx/chip.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Both now queued up, thanks. greg k-h
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 7c50d27bab76..1df7aed5ae15 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3051,7 +3051,7 @@ static const struct mv88e6xxx_ops mv88e6141_ops = { .port_link_state = mv88e6352_port_link_state, .port_get_cmode = mv88e6352_port_get_cmode, .stats_snapshot = mv88e6390_g1_stats_snapshot, - .stats_set_histogram = mv88e6095_g1_stats_set_histogram, + .stats_set_histogram = mv88e6390_g1_stats_set_histogram, .stats_get_sset_count = mv88e6320_stats_get_sset_count, .stats_get_strings = mv88e6320_stats_get_strings, .stats_get_stats = mv88e6390_stats_get_stats, @@ -3672,7 +3672,7 @@ static const struct mv88e6xxx_ops mv88e6341_ops = { .port_link_state = mv88e6352_port_link_state, .port_get_cmode = mv88e6352_port_get_cmode, .stats_snapshot = mv88e6390_g1_stats_snapshot, - .stats_set_histogram = mv88e6095_g1_stats_set_histogram, + .stats_set_histogram = mv88e6390_g1_stats_set_histogram, .stats_get_sset_count = mv88e6320_stats_get_sset_count, .stats_get_strings = mv88e6320_stats_get_strings, .stats_get_stats = mv88e6390_stats_get_stats,
commit 11527f3c4725640e6c40a2b7654e303f45e82a6c upstream. Commit 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") introduced wrong .stats_set_histogram() method for Topaz family. The Peridot method should be used instead. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)