| Message ID | 20210726094525.5748-1-brent.lu@intel.com |
|---|---|
| State | Accepted |
| Commit | 0f32d9eb38c13c32895b5bf695eac639cee02d6c |
| Headers | show |
| Series | ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard | expand |
On 7/26/21 4:45 AM, Brent Lu wrote: > The default codec for speaker amp's DAI Link is max98373 and will be > overwritten in probe function if the board id is sof_da7219_mx98360a. > However, the probe function does not do it because the board id is > changed in earlier commit. > > Fixes: 1cc04d195dc2 ("ASoC: Intel: sof_da7219_max98373: shrink platform_id below 20 characters") > Signed-off-by: Brent Lu <brent.lu@intel.com> Nice catch indeed. Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > sound/soc/intel/boards/sof_da7219_max98373.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/boards/sof_da7219_max98373.c b/sound/soc/intel/boards/sof_da7219_max98373.c > index 896251d742fe..b7b3b0bf994a 100644 > --- a/sound/soc/intel/boards/sof_da7219_max98373.c > +++ b/sound/soc/intel/boards/sof_da7219_max98373.c > @@ -404,7 +404,7 @@ static int audio_probe(struct platform_device *pdev) > return -ENOMEM; > > /* By default dais[0] is configured for max98373 */ > - if (!strcmp(pdev->name, "sof_da7219_max98360a")) { > + if (!strcmp(pdev->name, "sof_da7219_mx98360a")) { > dais[0] = (struct snd_soc_dai_link) { > .name = "SSP1-Codec", > .id = 0, >
diff --git a/sound/soc/intel/boards/sof_da7219_max98373.c b/sound/soc/intel/boards/sof_da7219_max98373.c index 896251d742fe..b7b3b0bf994a 100644 --- a/sound/soc/intel/boards/sof_da7219_max98373.c +++ b/sound/soc/intel/boards/sof_da7219_max98373.c @@ -404,7 +404,7 @@ static int audio_probe(struct platform_device *pdev) return -ENOMEM; /* By default dais[0] is configured for max98373 */ - if (!strcmp(pdev->name, "sof_da7219_max98360a")) { + if (!strcmp(pdev->name, "sof_da7219_mx98360a")) { dais[0] = (struct snd_soc_dai_link) { .name = "SSP1-Codec", .id = 0,
The default codec for speaker amp's DAI Link is max98373 and will be overwritten in probe function if the board id is sof_da7219_mx98360a. However, the probe function does not do it because the board id is changed in earlier commit. Fixes: 1cc04d195dc2 ("ASoC: Intel: sof_da7219_max98373: shrink platform_id below 20 characters") Signed-off-by: Brent Lu <brent.lu@intel.com> --- sound/soc/intel/boards/sof_da7219_max98373.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)