| Message ID | 1431893048-5214-3-git-send-email-parth.dixit@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 20 May 2015 at 20:42, Jan Beulich <JBeulich@suse.com> wrote: > >>> On 17.05.15 at 22:03, <parth.dixit@linaro.org> wrote: > > Pmstat is currently not supported for arm in xen. > > Configure and build pmstat for x86 architecture only. > > Same here as for patch 1. If the architecture can be expected to > eventually support a feature, I'd generally prefer the architecture > to get necessary stubs added over fiddling with common code. > > ok, will add stubs in next patchset. > > --- a/xen/common/sysctl.c > > +++ b/xen/common/sysctl.c > > @@ -170,6 +170,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) > u_sysctl) > > op->u.availheap.avail_bytes <<= PAGE_SHIFT; > > break; > > > > +#ifdef CONFIG_X86 > > #ifdef HAS_ACPI > > case XEN_SYSCTL_get_pmstat: > > ret = do_get_pm_info(&op->u.get_pmstat); > > Please fold the two #if-s into one, or even replace the HAS_ACPI > one if this really needs to be done. > > Jan > >
+shannon On 24 May 2015 at 11:40, Parth Dixit <parth.dixit@linaro.org> wrote: > > > On 20 May 2015 at 20:42, Jan Beulich <JBeulich@suse.com> wrote: >> >> >>> On 17.05.15 at 22:03, <parth.dixit@linaro.org> wrote: >> > Pmstat is currently not supported for arm in xen. >> > Configure and build pmstat for x86 architecture only. >> >> Same here as for patch 1. If the architecture can be expected to >> eventually support a feature, I'd generally prefer the architecture >> to get necessary stubs added over fiddling with common code. >> > ok, will add stubs in next patchset. >> >> > --- a/xen/common/sysctl.c >> > +++ b/xen/common/sysctl.c >> > @@ -170,6 +170,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) >> > u_sysctl) >> > op->u.availheap.avail_bytes <<= PAGE_SHIFT; >> > break; >> > >> > +#ifdef CONFIG_X86 >> > #ifdef HAS_ACPI >> > case XEN_SYSCTL_get_pmstat: >> > ret = do_get_pm_info(&op->u.get_pmstat); >> >> Please fold the two #if-s into one, or even replace the HAS_ACPI >> one if this really needs to be done. >> >> Jan >> >
diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c index 601dd09..96d06cf 100644 --- a/xen/common/sysctl.c +++ b/xen/common/sysctl.c @@ -170,6 +170,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) op->u.availheap.avail_bytes <<= PAGE_SHIFT; break; +#ifdef CONFIG_X86 #ifdef HAS_ACPI case XEN_SYSCTL_get_pmstat: ret = do_get_pm_info(&op->u.get_pmstat); @@ -181,6 +182,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) copyback = 1; break; #endif +#endif case XEN_SYSCTL_page_offline_op: { diff --git a/xen/drivers/acpi/Makefile b/xen/drivers/acpi/Makefile index 7294b5a..009fe5a 100644 --- a/xen/drivers/acpi/Makefile +++ b/xen/drivers/acpi/Makefile @@ -5,7 +5,7 @@ subdir-$(x86) += apei obj-bin-y += tables.init.o obj-$(x86) += numa.o obj-y += osl.o -obj-y += pmstat.o +obj-$(x86) += pmstat.o obj-$(x86) += hwregs.o obj-$(x86) += reboot.o
Pmstat is currently not supported for arm in xen. Configure and build pmstat for x86 architecture only. Signed-off-by: Parth Dixit <parth.dixit@linaro.org> --- xen/common/sysctl.c | 2 ++ xen/drivers/acpi/Makefile | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)