From patchwork Thu Jul 29 00:46:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 488634 Delivered-To: patch@linaro.org Received: by 2002:a05:6638:1185:0:0:0:0 with SMTP id f5csp1708488jas; Wed, 28 Jul 2021 18:03:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIsGxZVkU6L/zWwC+RB8lBCw1+4mSHEg/6bjA3JgWvqoOUF3H4kmanaDfhJRJSuMl7ah6u X-Received: by 2002:ac2:4a81:: with SMTP id l1mr1677825lfp.118.1627520583818; Wed, 28 Jul 2021 18:03:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627520583; cv=none; d=google.com; s=arc-20160816; b=nO9GRGcdpMkUrHl+BRJM2w2xmNJEY4oTNUZt1psLmd1VrnyWS2g68EZU04YyaAgq2D moHbB5kp2GrOnHFzDmYM6p8iPEYa/eEveipPRH2Nlytt16Il4//HYmONWZ+7zsZw9skN CDHf1PgU+6z5OPiomqc+MW/VRxQZ5ofQN90JTh36hdlVaE3Eg10CMshbrNTk5u30iUar wICpEWZpZ308Ql2lE3FZUmKAgkaQl9h39vFjI16P3x2vM/KIbJEoH+2U/CNpBz0xSI0Z X/7AuS/TQrmBjUykPypH07yHDAahk0zp+ps/rpnH+jopZRCzW1ZeFuhMDowSXV0ZQcjj QapA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=yQHwrcsq1PszUxdcPO+xJ5EXm+5xhLjl/eOGt9epIgI=; b=dCNaZ3Xf5xxpSpsWAxqdnNSSwt/giOd9LrW6DzUrjqvPUNFlfH6lfMCCxYCSWIjwje keinNCrjXGZDoDpp6/jxiKF7utgrUqudWFUdAlc6bBTOW8cMWcQSMiVdBKv2jPozyObl x2zQ8ctA9KOBaFQFY4Re7se0fI8yBuXENbzRSLpH1i1A933BrDCiBfrpH1ysrky46N7p F9/uBKVaQ/KqM6zGmHrbg/RH50YApqLGDSWmRJC/s4PY33PbnZO/cma1oH+rz5S00tIn jZ4kUPGday4h5AmppjMe1KuM7vu2Pq6Df0r0vMCkPxX8Qn0DAW4BqMprSbQsSLryx6wv kS/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="hJCEk0/g"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d23si1258454lji.239.2021.07.28.18.03.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Jul 2021 18:03:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="hJCEk0/g"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8uRy-0002yz-Jx for patch@linaro.org; Wed, 28 Jul 2021 21:03:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8uCa-0004La-U7 for qemu-devel@nongnu.org; Wed, 28 Jul 2021 20:47:09 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:46627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m8uCZ-0002XL-FF for qemu-devel@nongnu.org; Wed, 28 Jul 2021 20:47:08 -0400 Received: by mail-pj1-x1032.google.com with SMTP id g23-20020a17090a5797b02901765d605e14so6656363pji.5 for ; Wed, 28 Jul 2021 17:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yQHwrcsq1PszUxdcPO+xJ5EXm+5xhLjl/eOGt9epIgI=; b=hJCEk0/gCb6vopSFKmabt7zZD9HSL86R7ckRUCvxhXQMZEAFVURbN/qvDfX4JQbaEL O6xREx4Z72KY8W0hBfuiv/rdcOC2vWLJlHz0wv61o8LFIqmWGsCd9RSKOop6bRZKstAv MGLvbZ0G1rwMOULhV/h6Gnx2852DFB2vIyySfUyP433qlmJFzUCgpAuo6r5QgqENWY2c ma3d+BTzhTOIks1T1xu7NIP3XctfT4z6iTX2n4pkbAcnowNcA02iQSHY27ZEybV8otqT vAa6PHqwhQjpNQ/Ca1aEkBhSrG+8Bfg62lMuU+6IjLIWAhEsNgE+2lFNE865mt4GqVy2 sEAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yQHwrcsq1PszUxdcPO+xJ5EXm+5xhLjl/eOGt9epIgI=; b=RxDzdYRx9MCNM6DhMPmL0VtsKDDaA+ZJ1iMcO3mnTWbnJyjEsfXR9PjBbB0Xj+/39s n/3FrAhAI7P3ZaXLZ7e1NyoPvNop+FuCsgxNrudVCKijxR/64WLMNrKN6BxBHSPlozbg JwQIoQ1WF92+h61OJIJGLOWDGrBXfjYbrc5cm4I8qOmBH/yOyzCPoKPIQwMX2p9aJpJ1 fLA0qHxbp5bB+JprhSJkwfUWHigOglBpdCoiUNtcbXbLS+v36Erq5S4iNf0jdrkEvJcZ 9EKBkiPQiGD5HojGX9FULQ1vIIQTDAffW3TIq7ap/V4oXhdbkBF8wa43WNjH48ogjFS/ 05HQ== X-Gm-Message-State: AOAM530xWd8a6p8rZO628soZtwj9+INmIjVbKT13XG99nu3Q1EhBtBTL aWJH381ufORu1Ze6noSCgnqRSFK+KrUsCQ== X-Received: by 2002:a17:90a:c094:: with SMTP id o20mr2053109pjs.207.1627519626070; Wed, 28 Jul 2021 17:47:06 -0700 (PDT) Received: from cloudburst.home (2603-800c-3202-ffa7-dcaa-9e71-a2b2-2604.res6.spectrum.com. [2603:800c:3202:ffa7:dcaa:9e71:a2b2:2604]) by smtp.gmail.com with ESMTPSA id t205sm1305005pfc.32.2021.07.28.17.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 17:47:05 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH for-6.2 13/43] target/sparc: Remove DEBUG_UNALIGNED Date: Wed, 28 Jul 2021 14:46:17 -1000 Message-Id: <20210729004647.282017-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210729004647.282017-1-richard.henderson@linaro.org> References: <20210729004647.282017-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The printf should have been qemu_log_mask, the parameters themselves no longer compile, and because this is placed before unwinding the PC is actively wrong. We get better (and correct) logging on the other side of raising the exception, in sparc_cpu_do_interrupt. Cc: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/ldst_helper.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.25.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 22327d7d72..974afea041 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -27,7 +27,6 @@ //#define DEBUG_MMU //#define DEBUG_MXCC -//#define DEBUG_UNALIGNED //#define DEBUG_UNASSIGNED //#define DEBUG_ASI //#define DEBUG_CACHE_CONTROL @@ -364,10 +363,6 @@ static void do_check_align(CPUSPARCState *env, target_ulong addr, uint32_t align, uintptr_t ra) { if (addr & align) { -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, ra); } } @@ -1968,10 +1963,6 @@ void QEMU_NORETURN sparc_cpu_do_unaligned_access(CPUState *cs, vaddr addr, SPARCCPU *cpu = SPARC_CPU(cs); CPUSPARCState *env = &cpu->env; -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, retaddr); } #endif