| Message ID | 20210729072308.1908904-4-art@khadas.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | watchdog: meson_gxbb_wdt: improve | expand |
On 7/29/21 12:23 AM, Artem Lapkin wrote: > Remove watchdog_stop_on_reboot() > This warrants a much longer explanation to even be considered. Your explanation/reasoning needs to be here. Others won't have the benefit of reading the summary e-mail, even more so since you declined to number and sequence the series. Personally' I don't find it acceptable, but I'll be happy to listen to input from others. Such changes should be based on real problems, not on personal opinions. If we accept this patch, someone else might come in later reverting it with the personal opinion that some reboots take longer than the watchdog timeout. Guenter > Signed-off-by: Artem Lapkin <art@khadas.com> > --- > drivers/watchdog/meson_gxbb_wdt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > index 3f3866878..cafc6cdc0 100644 > --- a/drivers/watchdog/meson_gxbb_wdt.c > +++ b/drivers/watchdog/meson_gxbb_wdt.c > @@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) > > meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout); > > - watchdog_stop_on_reboot(&data->wdt_dev); > return devm_watchdog_register_device(dev, &data->wdt_dev); > } > >
Yes i totally agree with you , i will rewrite this patches again properly and explain more detail about why need remove watchdog_stop_on_reboot i have check already other watchdog sources / half of them have watchdog_stop_on_reboot another half dont have it , and i think both have some reasons > I'll be happy tolisten to input from others. Same will be happy. Our situation very simple - meson platform still have some hardware drivers problems for some configuration which can freeze device on shutdown/reboot stage and i hope better to have some reboot warranty > some reboots take longer than the watchdog timeout. I have check this situation to - our drivers shutdown stage its about 1 sec default watchdog timeout 30 sec i think its enough - cant see any problem anybody can use watchdog.stop_on_reboot=1 if need freeze identification. Artem On Thu, Jul 29, 2021 at 10:23 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On 7/29/21 12:23 AM, Artem Lapkin wrote: > > Remove watchdog_stop_on_reboot() > > > > This warrants a much longer explanation to even be considered. > Your explanation/reasoning needs to be here. Others won't have > the benefit of reading the summary e-mail, even more so since > you declined to number and sequence the series. > > Personally' I don't find it acceptable, but I'll be happy to > listen to input from others. Such changes should be based on > real problems, not on personal opinions. If we accept this patch, > someone else might come in later reverting it with the personal > opinion that some reboots take longer than the watchdog timeout. > > Guenter > > > Signed-off-by: Artem Lapkin <art@khadas.com> > > --- > > drivers/watchdog/meson_gxbb_wdt.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > > index 3f3866878..cafc6cdc0 100644 > > --- a/drivers/watchdog/meson_gxbb_wdt.c > > +++ b/drivers/watchdog/meson_gxbb_wdt.c > > @@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) > > > > meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout); > > > > - watchdog_stop_on_reboot(&data->wdt_dev); > > return devm_watchdog_register_device(dev, &data->wdt_dev); > > } > > > > >
diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c index 3f3866878..cafc6cdc0 100644 --- a/drivers/watchdog/meson_gxbb_wdt.c +++ b/drivers/watchdog/meson_gxbb_wdt.c @@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout); - watchdog_stop_on_reboot(&data->wdt_dev); return devm_watchdog_register_device(dev, &data->wdt_dev); }
Remove watchdog_stop_on_reboot() Signed-off-by: Artem Lapkin <art@khadas.com> --- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-)