| Message ID | 20210730030540.1098438-1-jkacur@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | rteval: Add __contains__ in rtevalConfig | expand |
diff --git a/rteval/rtevalConfig.py b/rteval/rtevalConfig.py index 578aaa3ab58f..56bbc9ee0de6 100644 --- a/rteval/rtevalConfig.py +++ b/rteval/rtevalConfig.py @@ -126,6 +126,8 @@ class rtevalCfgSection: return self.__cfgdata[key] return None + def __contains__(self, key): + return key in self.__cfgdata def items(self): return list(self.__cfgdata.items())
Add the __contains__ function to the rtevalCfgSection class to make "in" function correctly. For example in cyclictest.py, self.__cfg is not a dictionary, it is an instance of the rtevalCfgSection class, therefore key in self.__cfg does not work as expected. In order to make sure this is fixed everywhere, instead of comparing to self.__cfg.keys() everywhere this is used, implement the __contains__ function so that "in" works as expected. This bug was introduced by the commit fd3b732f714d ("rteval: 2to3 transformations") Reported-by: Atsushi Nemoto <atsushi.nemoto@sord.co.jp> Signed-off-by: John Kacur <jkacur@redhat.com> Correction Suggested-by: Jeff Epler <jepler@unpythonic.net> Signed-off-by: John Kacur <jkacur@redhat.com> --- rteval/rtevalConfig.py | 2 ++ 1 file changed, 2 insertions(+)