diff mbox series

[01/11] dt-bindings: usb: mtk-xhci: add support property 'tpl-support'

Message ID 1627635002-24521-1-git-send-email-chunfeng.yun@mediatek.com
State New
Headers show
Series [01/11] dt-bindings: usb: mtk-xhci: add support property 'tpl-support' | expand

Commit Message

Chunfeng Yun (云春峰) July 30, 2021, 8:49 a.m. UTC
Add property 'tpl-support' to support targeted peripheral list
for USB-IF Embedded Host Compliance Test

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
 Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring Aug. 6, 2021, 8:37 p.m. UTC | #1
On Fri, Jul 30, 2021 at 04:49:52PM +0800, Chunfeng Yun wrote:
> Add property 'tpl-support' to support targeted peripheral list

> for USB-IF Embedded Host Compliance Test


Given you have to configure the TPL somehow, how is this useful to be in 
DT? And no, that's not a suggestion to put all the TPL config into DT.

> 

> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

> ---

>  Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml

> index 240882b12565..49729aab6d1a 100644

> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml

> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml

> @@ -115,6 +115,8 @@ properties:

>  

>    usb2-lpm-disable: true

>  

> +  tpl-support: true

> +

>    imod-interval-ns:

>      description:

>        Interrupt moderation interval value, it is 8 times as much as that

> -- 

> 2.18.0

> 

>
Chunfeng Yun (云春峰) Aug. 11, 2021, 7:54 a.m. UTC | #2
On Fri, 2021-08-06 at 14:37 -0600, Rob Herring wrote:
> On Fri, Jul 30, 2021 at 04:49:52PM +0800, Chunfeng Yun wrote:

> > Add property 'tpl-support' to support targeted peripheral list

> > for USB-IF Embedded Host Compliance Test

> 

> Given you have to configure the TPL somehow, how is this useful to be

> in 

> DT? And no, that's not a suggestion to put all the TPL config into

> DT.

Ok, will abandon this patch

Thanks

> 

> > 

> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

> > ---

> >  Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 2

> > ++

> >  1 file changed, 2 insertions(+)

> > 

> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-

> > xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-

> > xhci.yaml

> > index 240882b12565..49729aab6d1a 100644

> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml

> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml

> > @@ -115,6 +115,8 @@ properties:

> >  

> >    usb2-lpm-disable: true

> >  

> > +  tpl-support: true

> > +

> >    imod-interval-ns:

> >      description:

> >        Interrupt moderation interval value, it is 8 times as much

> > as that

> > -- 

> > 2.18.0

> > 

> >
Chunfeng Yun (云春峰) Aug. 12, 2021, 2:28 a.m. UTC | #3
On Fri, 2021-08-06 at 14:37 -0600, Rob Herring wrote:
> On Fri, Jul 30, 2021 at 04:49:52PM +0800, Chunfeng Yun wrote:

> > Add property 'tpl-support' to support targeted peripheral list

> > for USB-IF Embedded Host Compliance Test

> 

> Given you have to configure the TPL somehow, how is this useful to be

> in 

> DT? And no, that's not a suggestion to put all the TPL config into

> DT.

It's indeed not flexible here, abandon this patch.

Thanks

> 

> > 

> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

> > ---

> >  Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 2

> > ++

> >  1 file changed, 2 insertions(+)

> > 

> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-

> > xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-

> > xhci.yaml

> > index 240882b12565..49729aab6d1a 100644

> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml

> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml

> > @@ -115,6 +115,8 @@ properties:

> >  

> >    usb2-lpm-disable: true

> >  

> > +  tpl-support: true

> > +

> >    imod-interval-ns:

> >      description:

> >        Interrupt moderation interval value, it is 8 times as much

> > as that

> > -- 

> > 2.18.0

> > 

> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
index 240882b12565..49729aab6d1a 100644
--- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
+++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
@@ -115,6 +115,8 @@  properties:
 
   usb2-lpm-disable: true
 
+  tpl-support: true
+
   imod-interval-ns:
     description:
       Interrupt moderation interval value, it is 8 times as much as that