diff mbox series

qlcnic: make the array random_data static const, makes object smaller

Message ID 20210801151659.146113-1-colin.king@canonical.com
State New
Headers show
Series qlcnic: make the array random_data static const, makes object smaller | expand

Commit Message

Colin King Aug. 1, 2021, 3:16 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Don't populate the array random_data on the stack but instead it
static const. Makes the object code smaller by 66 bytes.

Before:
   text    data     bss     dec     hex filename
  52895   10976       0   63871    f97f ../qlogic/qlcnic/qlcnic_ethtool.o

After:
   text    data     bss     dec     hex filename
  52701   11104       0   63805    f93d ../qlogic//qlcnic/qlcnic_ethtool.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 2, 2021, 10:10 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sun,  1 Aug 2021 16:16:59 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>

> 

> Don't populate the array random_data on the stack but instead it

> static const. Makes the object code smaller by 66 bytes.

> 

> Before:

>    text    data     bss     dec     hex filename

>   52895   10976       0   63871    f97f ../qlogic/qlcnic/qlcnic_ethtool.o

> 

> [...]


Here is the summary with links:
  - qlcnic: make the array random_data static const, makes object smaller
    https://git.kernel.org/netdev/net-next/c/a6afdb041a2d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
index d8f0863b3934..f6b6651decf3 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
@@ -1021,7 +1021,7 @@  static int qlcnic_irq_test(struct net_device *netdev)
 
 static void qlcnic_create_loopback_buff(unsigned char *data, u8 mac[])
 {
-	unsigned char random_data[] = {0xa8, 0x06, 0x45, 0x00};
+	static const unsigned char random_data[] = {0xa8, 0x06, 0x45, 0x00};
 
 	memset(data, 0x4e, QLCNIC_ILB_PKT_SIZE);