| Message ID | 20210802102654.5996-5-biju.das.jz@bp.renesas.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add Gigabit Ethernet driver support | expand |
On 8/2/21 1:26 PM, Biju Das wrote: > R-Car provides 30 device stats, whereas RZ/G2L provides only 15. In > addition, RZ/G2L has stats "rx_queue_0_csum_offload_errors" instead of > "rx_queue_0_missed_errors". > > Replace RAVB_STATS_LEN macro with a structure variable stats_len to > struct ravb_hw_info, to support subsequent SoCs without any code changes > to the ravb_get_sset_count function. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> [...] Finally a patch that I can agree with. :-) Reviewed-by: ergei Shtylyov <sergei.shtylyov@gmail.com> MBR, Sergei
Hi Sergei, > Subject: Re: [PATCH net-next v2 4/8] ravb: Add stats_len to struct > ravb_hw_info > > On 8/2/21 1:26 PM, Biju Das wrote: > > > R-Car provides 30 device stats, whereas RZ/G2L provides only 15. In > > addition, RZ/G2L has stats "rx_queue_0_csum_offload_errors" instead of > > "rx_queue_0_missed_errors". > > > > Replace RAVB_STATS_LEN macro with a structure variable stats_len to > > struct ravb_hw_info, to support subsequent SoCs without any code > > changes to the ravb_get_sset_count function. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > [...] > > Finally a patch that I can agree with. :-) > > Reviewed-by: ergei Shtylyov <sergei.shtylyov@gmail.com> ^Typo here. Cheers, Biju
On 8/3/21 9:47 PM, Biju Das wrote: [...] >>> R-Car provides 30 device stats, whereas RZ/G2L provides only 15. In >>> addition, RZ/G2L has stats "rx_queue_0_csum_offload_errors" instead of >>> "rx_queue_0_missed_errors". >>> >>> Replace RAVB_STATS_LEN macro with a structure variable stats_len to >>> struct ravb_hw_info, to support subsequent SoCs without any code >>> changes to the ravb_get_sset_count function. >>> >>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> >>> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> >> [...] >> >> Finally a patch that I can agree with. :-) >> >> Reviewed-by: ergei Shtylyov <sergei.shtylyov@gmail.com> > ^Typo here. Sorry, here's a good one: Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com> > Cheers, > Biju MBR, Sergei
diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h index 38552e0319d3..a42c34eaebc2 100644 --- a/drivers/net/ethernet/renesas/ravb.h +++ b/drivers/net/ethernet/renesas/ravb.h @@ -992,6 +992,7 @@ struct ravb_hw_info { enum ravb_chip_id chip_id; int num_gstat_queue; int num_tx_desc; + int stats_len; size_t skb_sz; }; diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 30132693edd7..baeb868b07ed 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -1133,13 +1133,14 @@ static const char ravb_gstrings_stats[][ETH_GSTRING_LEN] = { "rx_queue_1_over_errors", }; -#define RAVB_STATS_LEN ARRAY_SIZE(ravb_gstrings_stats) - static int ravb_get_sset_count(struct net_device *netdev, int sset) { + struct ravb_private *priv = netdev_priv(netdev); + const struct ravb_hw_info *info = priv->info; + switch (sset) { case ETH_SS_STATS: - return RAVB_STATS_LEN; + return info->stats_len; default: return -EOPNOTSUPP; } @@ -1929,6 +1930,7 @@ static const struct ravb_hw_info ravb_gen3_hw_info = { .chip_id = RCAR_GEN3, .num_gstat_queue = NUM_RX_QUEUE, .num_tx_desc = NUM_TX_DESC_GEN3, + .stats_len = ARRAY_SIZE(ravb_gstrings_stats), .skb_sz = RX_BUF_SZ + RAVB_ALIGN - 1, }; @@ -1936,6 +1938,7 @@ static const struct ravb_hw_info ravb_gen2_hw_info = { .chip_id = RCAR_GEN2, .num_gstat_queue = NUM_RX_QUEUE, .num_tx_desc = NUM_TX_DESC_GEN2, + .stats_len = ARRAY_SIZE(ravb_gstrings_stats), .skb_sz = RX_BUF_SZ + RAVB_ALIGN - 1, };