diff mbox series

scsi: fix missing FORCE for scsi_devinfo_tbl.c build rule

Message ID 20210819012339.709409-1-masahiroy@kernel.org
State New
Headers show
Series scsi: fix missing FORCE for scsi_devinfo_tbl.c build rule | expand

Commit Message

Masahiro Yamada Aug. 19, 2021, 1:23 a.m. UTC
Add FORCE so that if_changed can detect the command line change.
scsi_devinfo_tbl.c must be added to 'targets' too.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 drivers/scsi/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Martin K. Petersen Aug. 24, 2021, 3:05 a.m. UTC | #1
Masahiro,

> Add FORCE so that if_changed can detect the command line change.

> scsi_devinfo_tbl.c must be added to 'targets' too.


Applied to 5.15/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Martin K. Petersen Aug. 28, 2021, 2:32 a.m. UTC | #2
On Thu, 19 Aug 2021 10:23:39 +0900, Masahiro Yamada wrote:

> Add FORCE so that if_changed can detect the command line change.

> scsi_devinfo_tbl.c must be added to 'targets' too.

> 

> 

> 

> 


Applied to 5.15/scsi-queue, thanks!

[1/1] scsi: fix missing FORCE for scsi_devinfo_tbl.c build rule
      https://git.kernel.org/mkp/scsi/c/98079418c53f

-- 
Martin K. Petersen	Oracle Linux Engineering
diff mbox series

Patch

diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
index 1748d1ec1338..77812ba3c4aa 100644
--- a/drivers/scsi/Makefile
+++ b/drivers/scsi/Makefile
@@ -183,7 +183,7 @@  CFLAGS_ncr53c8xx.o	:= $(ncr53c8xx-flags-y) $(ncr53c8xx-flags-m)
 zalon7xx-objs	:= zalon.o ncr53c8xx.o
 
 # Files generated that shall be removed upon make clean
-clean-files :=	53c700_d.h 53c700_u.h scsi_devinfo_tbl.c
+clean-files :=	53c700_d.h 53c700_u.h
 
 $(obj)/53c700.o: $(obj)/53c700_d.h
 
@@ -192,9 +192,11 @@  $(obj)/scsi_sysfs.o: $(obj)/scsi_devinfo_tbl.c
 quiet_cmd_bflags = GEN     $@
 	cmd_bflags = sed -n 's/.*define *BLIST_\([A-Z0-9_]*\) *.*/BLIST_FLAG_NAME(\1),/p' $< > $@
 
-$(obj)/scsi_devinfo_tbl.c: include/scsi/scsi_devinfo.h
+$(obj)/scsi_devinfo_tbl.c: include/scsi/scsi_devinfo.h FORCE
 	$(call if_changed,bflags)
 
+targets +=  scsi_devinfo_tbl.c
+
 # If you want to play with the firmware, uncomment
 # GENERATE_FIRMWARE := 1