diff mbox series

drm/msm: remove unneeded variable

Message ID 20210831115127.18236-1-chi.minghao@zte.com.cn
State New
Headers show
Series drm/msm: remove unneeded variable | expand

Commit Message

Lv Ruyi Aug. 31, 2021, 11:51 a.m. UTC 
From: Chi Minghao <chi.minghao@zte.com.cn>

Fix the following coccicheck REVIEW:
./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Chi Minghao <chi.minghao@zte.com.cn>
---
 drivers/gpu/drm/msm/edp/edp_ctrl.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Lyude Paul Sept. 2, 2021, 6:40 p.m. UTC | #1 
Reviewed-by: Lyude Paul <lyude@redhat.com>


Do you need me to push this?

On Tue, 2021-08-31 at 04:51 -0700, cgel.zte@gmail.com wrote:
> From: Chi Minghao <chi.minghao@zte.com.cn>

> 

> Fix the following coccicheck REVIEW:

> ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable

> 

> Reported-by: Zeal Robot <zealci@zte.com.cn>

> Signed-off-by: Chi Minghao <chi.minghao@zte.com.cn>

> ---

>  drivers/gpu/drm/msm/edp/edp_ctrl.c | 4 +---

>  1 file changed, 1 insertion(+), 3 deletions(-)

> 

> diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c

> b/drivers/gpu/drm/msm/edp/edp_ctrl.c

> index 4fb397ee7c84..3610e26e62fa 100644

> --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c

> +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c

> @@ -1242,8 +1242,6 @@ bool msm_edp_ctrl_panel_connected(struct edp_ctrl

> *ctrl)

>  int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,

>                 struct drm_connector *connector, struct edid **edid)

>  {

> -       int ret = 0;

> -

>         mutex_lock(&ctrl->dev_mutex);

>  

>         if (ctrl->edid) {

> @@ -1278,7 +1276,7 @@ int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,

>         }

>  unlock_ret:

>         mutex_unlock(&ctrl->dev_mutex);

> -       return ret;

> +       return 0;

>  }

>  

>  int msm_edp_ctrl_timing_cfg(struct edp_ctrl *ctrl,


-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat
Dmitry Baryshkov Sept. 3, 2021, 6:31 p.m. UTC | #2 
On 02/09/2021 21:40, Lyude Paul wrote:
> Reviewed-by: Lyude Paul <lyude@redhat.com>
> 
> Do you need me to push this?

We'd pick this up through the msm tree.

> 
> On Tue, 2021-08-31 at 04:51 -0700, cgel.zte@gmail.com wrote:
>> From: Chi Minghao <chi.minghao@zte.com.cn>
>>
>> Fix the following coccicheck REVIEW:
>> ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable
>>
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: Chi Minghao <chi.minghao@zte.com.cn>
>> ---
>>   drivers/gpu/drm/msm/edp/edp_ctrl.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c
>> b/drivers/gpu/drm/msm/edp/edp_ctrl.c
>> index 4fb397ee7c84..3610e26e62fa 100644
>> --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
>> +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
>> @@ -1242,8 +1242,6 @@ bool msm_edp_ctrl_panel_connected(struct edp_ctrl
>> *ctrl)
>>   int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
>>                  struct drm_connector *connector, struct edid **edid)
>>   {
>> -       int ret = 0;
>> -
>>          mutex_lock(&ctrl->dev_mutex);
>>   
>>          if (ctrl->edid) {
>> @@ -1278,7 +1276,7 @@ int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
>>          }
>>   unlock_ret:
>>          mutex_unlock(&ctrl->dev_mutex);
>> -       return ret;
>> +       return 0;
>>   }
>>   
>>   int msm_edp_ctrl_timing_cfg(struct edp_ctrl *ctrl,
>
Lyude Paul Sept. 3, 2021, 6:40 p.m. UTC | #3 
On Fri, 2021-09-03 at 21:31 +0300, Dmitry Baryshkov wrote:
> On 02/09/2021 21:40, Lyude Paul wrote:

> > Reviewed-by: Lyude Paul <lyude@redhat.com>

> > 

> > Do you need me to push this?

> 

> We'd pick this up through the msm tree.


ah-totally forgot msm had their own tree and didn't go through drm-misc-next.
Thanks!

> 

> > 

> > On Tue, 2021-08-31 at 04:51 -0700, cgel.zte@gmail.com wrote:

> > > From: Chi Minghao <chi.minghao@zte.com.cn>

> > > 

> > > Fix the following coccicheck REVIEW:

> > > ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable

> > > 

> > > Reported-by: Zeal Robot <zealci@zte.com.cn>

> > > Signed-off-by: Chi Minghao <chi.minghao@zte.com.cn>

> > > ---

> > >   drivers/gpu/drm/msm/edp/edp_ctrl.c | 4 +---

> > >   1 file changed, 1 insertion(+), 3 deletions(-)

> > > 

> > > diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c

> > > b/drivers/gpu/drm/msm/edp/edp_ctrl.c

> > > index 4fb397ee7c84..3610e26e62fa 100644

> > > --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c

> > > +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c

> > > @@ -1242,8 +1242,6 @@ bool msm_edp_ctrl_panel_connected(struct edp_ctrl

> > > *ctrl)

> > >   int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,

> > >                  struct drm_connector *connector, struct edid **edid)

> > >   {

> > > -       int ret = 0;

> > > -

> > >          mutex_lock(&ctrl->dev_mutex);

> > >   

> > >          if (ctrl->edid) {

> > > @@ -1278,7 +1276,7 @@ int msm_edp_ctrl_get_panel_info(struct edp_ctrl

> > > *ctrl,

> > >          }

> > >   unlock_ret:

> > >          mutex_unlock(&ctrl->dev_mutex);

> > > -       return ret;

> > > +       return 0;

> > >   }

> > >   

> > >   int msm_edp_ctrl_timing_cfg(struct edp_ctrl *ctrl,

> > 

> 

> 


-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat
Dmitry Baryshkov Sept. 3, 2021, 6:51 p.m. UTC | #4 
On 31/08/2021 14:51, cgel.zte@gmail.com wrote:
> From: Chi Minghao <chi.minghao@zte.com.cn>

> 

> Fix the following coccicheck REVIEW:

> ./drivers/gpu/drm/msm/edp/edp_ctrl.c:1245:5-8 Unneeded variable

> 

> Reported-by: Zeal Robot <zealci@zte.com.cn>

> Signed-off-by: Chi Minghao <chi.minghao@zte.com.cn>


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


Glancing on msm/edp, as it was never supported by the in-kernel dts I 
wonder: maybe we should drop it completely? If the need arises the 
removal can be reverted anytime.

Does anybody hacking 8084/8074/8974 support has eDP port access?

> ---

>   drivers/gpu/drm/msm/edp/edp_ctrl.c | 4 +---

>   1 file changed, 1 insertion(+), 3 deletions(-)

> 

> diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c b/drivers/gpu/drm/msm/edp/edp_ctrl.c

> index 4fb397ee7c84..3610e26e62fa 100644

> --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c

> +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c

> @@ -1242,8 +1242,6 @@ bool msm_edp_ctrl_panel_connected(struct edp_ctrl *ctrl)

>   int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,

>   		struct drm_connector *connector, struct edid **edid)

>   {

> -	int ret = 0;

> -

>   	mutex_lock(&ctrl->dev_mutex);

>   

>   	if (ctrl->edid) {

> @@ -1278,7 +1276,7 @@ int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,

>   	}

>   unlock_ret:

>   	mutex_unlock(&ctrl->dev_mutex);

> -	return ret;

> +	return 0;

>   }

>   

>   int msm_edp_ctrl_timing_cfg(struct edp_ctrl *ctrl,

> 



-- 
With best wishes
Dmitry
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c b/drivers/gpu/drm/msm/edp/edp_ctrl.c
index 4fb397ee7c84..3610e26e62fa 100644
--- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
+++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
@@ -1242,8 +1242,6 @@  bool msm_edp_ctrl_panel_connected(struct edp_ctrl *ctrl)
 int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
 		struct drm_connector *connector, struct edid **edid)
 {
-	int ret = 0;
-
 	mutex_lock(&ctrl->dev_mutex);
 
 	if (ctrl->edid) {
@@ -1278,7 +1276,7 @@  int msm_edp_ctrl_get_panel_info(struct edp_ctrl *ctrl,
 	}
 unlock_ret:
 	mutex_unlock(&ctrl->dev_mutex);
-	return ret;
+	return 0;
 }
 
 int msm_edp_ctrl_timing_cfg(struct edp_ctrl *ctrl,