| Message ID | 20210901091852.479202-49-maxime@cerno.tech |
|---|---|
| State | Accepted |
| Commit | e1b123a9308532941a28ebccdb3b024c45158acb |
| Headers | show |
| Series | ARM: dts: Last round of DT schema fixes | expand |
Dne sreda, 01. september 2021 ob 11:18:48 CEST je Maxime Ripard napisal(a): > While it doesn't really matter from a functional point of view in this > driver's case, it's usually a good practice to list the clocks in a > driver in the same driver across all its users. > > The H6 is using the inverse order than all the other users, so let's > make it consistent. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej
On Sun, Sep 05, 2021 at 11:13:25PM +0200, Jernej Škrabec wrote: > Dne sreda, 01. september 2021 ob 11:18:48 CEST je Maxime Ripard napisal(a): > > While it doesn't really matter from a functional point of view in this > > driver's case, it's usually a good practice to list the clocks in a > > driver in the same driver across all its users. > > > > The H6 is using the inverse order than all the other users, so let's > > make it consistent. > > > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > > Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Applied, thanks Maxime
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index 30d396e8c762..46ed529a4dc2 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi @@ -119,10 +119,10 @@ bus@1000000 { display_clocks: clock@0 { compatible = "allwinner,sun50i-h6-de3-clk"; reg = <0x0 0x10000>; - clocks = <&ccu CLK_DE>, - <&ccu CLK_BUS_DE>; - clock-names = "mod", - "bus"; + clocks = <&ccu CLK_BUS_DE>, + <&ccu CLK_DE>; + clock-names = "bus", + "mod"; resets = <&ccu RST_BUS_DE>; #clock-cells = <1>; #reset-cells = <1>;
While it doesn't really matter from a functional point of view in this driver's case, it's usually a good practice to list the clocks in a driver in the same driver across all its users. The H6 is using the inverse order than all the other users, so let's make it consistent. Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)