diff mbox series

[3/3] dt-bindings: display: msm: Add binding for msm8998 dpu

Message ID 20210901181138.1052653-3-angelogioacchino.delregno@somainline.org
State Accepted
Commit 6e986a8f1cf15810be49e439acbc4a1499dd64b7
Headers show
Series [1/3] drm/msm/dpu1: Add DMA2, DMA3 clock control to enum | expand

Commit Message

AngeloGioacchino Del Regno Sept. 1, 2021, 6:11 p.m. UTC
Add yaml binding for msm8998 dpu1 support.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
---
 .../bindings/display/msm/dpu-msm8998.yaml     | 220 ++++++++++++++++++
 1 file changed, 220 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml

Comments

Rob Herring Sept. 7, 2021, 6:37 p.m. UTC | #1
On Wed, Sep 01, 2021 at 08:11:38PM +0200, AngeloGioacchino Del Regno wrote:
> Add yaml binding for msm8998 dpu1 support.

> 

> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

> ---

>  .../bindings/display/msm/dpu-msm8998.yaml     | 220 ++++++++++++++++++

>  1 file changed, 220 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml

> 

> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml

> new file mode 100644

> index 000000000000..db435342ecbf

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml

> @@ -0,0 +1,220 @@

> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/display/msm/dpu-msm8998.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title: Qualcomm Display DPU dt properties for MSM8998 target

> +

> +maintainers:

> +  - AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

> +

> +description: |

> +  Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates

> +  sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree

> +  bindings of MDSS and DPU are mentioned for MSM8998 target.

> +

> +properties:

> +  compatible:

> +    items:

> +      - const: qcom,msm8998-mdss

> +

> +  reg:

> +    maxItems: 1

> +

> +  reg-names:

> +    const: mdss

> +

> +  power-domains:

> +    maxItems: 1

> +

> +  clocks:

> +    items:

> +      - description: Display AHB clock

> +      - description: Display AXI clock

> +      - description: Display core clock

> +

> +  clock-names:

> +    items:

> +      - const: iface

> +      - const: bus

> +      - const: core

> +

> +  interrupts:

> +    maxItems: 1

> +

> +  interrupt-controller: true

> +

> +  "#address-cells": true

> +

> +  "#size-cells": true

> +

> +  "#interrupt-cells":

> +    const: 1

> +

> +  iommus:

> +    items:

> +      - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0

> +

> +  ranges: true

> +

> +patternProperties:

> +  "^display-controller@[0-9a-f]+$":

> +    type: object

> +    description: Node containing the properties of DPU.

> +

> +    properties:

> +      compatible:

> +        items:

> +          - const: qcom,msm8998-dpu

> +

> +      reg:

> +        items:

> +          - description: Address offset and size for mdp register set

> +          - description: Address offset and size for regdma register set

> +          - description: Address offset and size for vbif register set

> +          - description: Address offset and size for non-realtime vbif register set

> +

> +      reg-names:

> +        items:

> +          - const: mdp

> +          - const: regdma

> +          - const: vbif

> +          - const: vbif_nrt

> +

> +      clocks:

> +        items:

> +          - description: Display ahb clock

> +          - description: Display axi clock

> +          - description: Display mem-noc clock

> +          - description: Display core clock

> +          - description: Display vsync clock

> +

> +      clock-names:

> +        items:

> +          - const: iface

> +          - const: bus

> +          - const: mnoc

> +          - const: core

> +          - const: vsync

> +

> +      interrupts:

> +        maxItems: 1

> +

> +      power-domains:

> +        maxItems: 1

> +

> +      operating-points-v2: true

> +      ports:

> +        $ref: /schemas/graph.yaml#/properties/ports

> +        description: |

> +          Contains the list of output ports from DPU device. These ports

> +          connect to interfaces that are external to the DPU hardware,

> +          such as DSI, DP etc. Each output port contains an endpoint that

> +          describes how it is connected to an external interface.

> +

> +        properties:

> +          port@0:

> +            $ref: /schemas/graph.yaml#/properties/port

> +            description: DPU_INTF1 (DSI1)

> +

> +          port@1:

> +            $ref: /schemas/graph.yaml#/properties/port

> +            description: DPU_INTF2 (DSI2)

> +

> +        required:

> +          - port@0

> +          - port@1

> +

> +    required:

> +      - compatible

> +      - reg

> +      - reg-names

> +      - clocks

> +      - interrupts

> +      - power-domains

> +      - operating-points-v2

> +      - ports

> +

> +required:

> +  - compatible

> +  - reg

> +  - reg-names

> +  - power-domains

> +  - clocks

> +  - interrupts

> +  - interrupt-controller

> +  - iommus

> +  - ranges

> +

> +additionalProperties: false

> +

> +examples:

> +  - |

> +    #include <dt-bindings/clock/qcom,mmcc-msm8998.h>

> +    #include <dt-bindings/interrupt-controller/arm-gic.h>

> +    #include <dt-bindings/power/qcom-rpmpd.h>

> +

> +    display-subsystem@c900000 {

> +        compatible = "qcom,msm8998-mdss";

> +        reg = <0x0c900000 0x1000>;

> +        reg-names = "mdss";

> +

> +        clocks = <&mmcc MDSS_AHB_CLK>,

> +                 <&mmcc MDSS_AXI_CLK>,

> +                 <&mmcc MDSS_MDP_CLK>;

> +        clock-names = "iface", "bus", "core";

> +

> +        #address-cells = <1>;

> +        #interrupt-cells = <1>;

> +        #size-cells = <1>;

> +

> +        interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;

> +        interrupt-controller;

> +        iommus = <&mmss_smmu 0>;

> +

> +        power-domains = <&mmcc MDSS_GDSC>;

> +        ranges;

> +        status = "disabled";


Drop. Why disable an example?

> +

> +        display-controller@c901000 {

> +            compatible = "qcom,msm8998-dpu";

> +            reg = <0x0c901000 0x8f000>,

> +                  <0x0c9a8e00 0xf0>,

> +                  <0x0c9b0000 0x2008>,

> +                  <0x0c9b8000 0x1040>;

> +            reg-names = "mdp", "regdma", "vbif", "vbif_nrt";

> +

> +            clocks = <&mmcc MDSS_AHB_CLK>,

> +                     <&mmcc MDSS_AXI_CLK>,

> +                     <&mmcc MNOC_AHB_CLK>,

> +                     <&mmcc MDSS_MDP_CLK>,

> +                     <&mmcc MDSS_VSYNC_CLK>;

> +            clock-names = "iface", "bus", "mnoc", "core", "vsync";

> +

> +            interrupt-parent = <&mdss>;

> +            interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;

> +            operating-points-v2 = <&mdp_opp_table>;

> +            power-domains = <&rpmpd MSM8998_VDDMX>;

> +

> +            ports {

> +                #address-cells = <1>;

> +                #size-cells = <0>;

> +

> +                port@0 {

> +                    reg = <0>;

> +                    dpu_intf1_out: endpoint {

> +                        remote-endpoint = <&dsi0_in>;

> +                    };

> +                };

> +

> +                port@1 {

> +                    reg = <1>;

> +                    dpu_intf2_out: endpoint {

> +                        remote-endpoint = <&dsi1_in>;

> +                    };

> +                };

> +            };

> +        };

> +    };

> +...

> -- 

> 2.32.0

> 

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
new file mode 100644
index 000000000000..db435342ecbf
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
@@ -0,0 +1,220 @@ 
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/dpu-msm8998.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Display DPU dt properties for MSM8998 target
+
+maintainers:
+  - AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
+
+description: |
+  Device tree bindings for MSM Mobile Display Subsystem(MDSS) that encapsulates
+  sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree
+  bindings of MDSS and DPU are mentioned for MSM8998 target.
+
+properties:
+  compatible:
+    items:
+      - const: qcom,msm8998-mdss
+
+  reg:
+    maxItems: 1
+
+  reg-names:
+    const: mdss
+
+  power-domains:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: Display AHB clock
+      - description: Display AXI clock
+      - description: Display core clock
+
+  clock-names:
+    items:
+      - const: iface
+      - const: bus
+      - const: core
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-controller: true
+
+  "#address-cells": true
+
+  "#size-cells": true
+
+  "#interrupt-cells":
+    const: 1
+
+  iommus:
+    items:
+      - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
+
+  ranges: true
+
+patternProperties:
+  "^display-controller@[0-9a-f]+$":
+    type: object
+    description: Node containing the properties of DPU.
+
+    properties:
+      compatible:
+        items:
+          - const: qcom,msm8998-dpu
+
+      reg:
+        items:
+          - description: Address offset and size for mdp register set
+          - description: Address offset and size for regdma register set
+          - description: Address offset and size for vbif register set
+          - description: Address offset and size for non-realtime vbif register set
+
+      reg-names:
+        items:
+          - const: mdp
+          - const: regdma
+          - const: vbif
+          - const: vbif_nrt
+
+      clocks:
+        items:
+          - description: Display ahb clock
+          - description: Display axi clock
+          - description: Display mem-noc clock
+          - description: Display core clock
+          - description: Display vsync clock
+
+      clock-names:
+        items:
+          - const: iface
+          - const: bus
+          - const: mnoc
+          - const: core
+          - const: vsync
+
+      interrupts:
+        maxItems: 1
+
+      power-domains:
+        maxItems: 1
+
+      operating-points-v2: true
+      ports:
+        $ref: /schemas/graph.yaml#/properties/ports
+        description: |
+          Contains the list of output ports from DPU device. These ports
+          connect to interfaces that are external to the DPU hardware,
+          such as DSI, DP etc. Each output port contains an endpoint that
+          describes how it is connected to an external interface.
+
+        properties:
+          port@0:
+            $ref: /schemas/graph.yaml#/properties/port
+            description: DPU_INTF1 (DSI1)
+
+          port@1:
+            $ref: /schemas/graph.yaml#/properties/port
+            description: DPU_INTF2 (DSI2)
+
+        required:
+          - port@0
+          - port@1
+
+    required:
+      - compatible
+      - reg
+      - reg-names
+      - clocks
+      - interrupts
+      - power-domains
+      - operating-points-v2
+      - ports
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - power-domains
+  - clocks
+  - interrupts
+  - interrupt-controller
+  - iommus
+  - ranges
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/qcom,mmcc-msm8998.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/power/qcom-rpmpd.h>
+
+    display-subsystem@c900000 {
+        compatible = "qcom,msm8998-mdss";
+        reg = <0x0c900000 0x1000>;
+        reg-names = "mdss";
+
+        clocks = <&mmcc MDSS_AHB_CLK>,
+                 <&mmcc MDSS_AXI_CLK>,
+                 <&mmcc MDSS_MDP_CLK>;
+        clock-names = "iface", "bus", "core";
+
+        #address-cells = <1>;
+        #interrupt-cells = <1>;
+        #size-cells = <1>;
+
+        interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
+        interrupt-controller;
+        iommus = <&mmss_smmu 0>;
+
+        power-domains = <&mmcc MDSS_GDSC>;
+        ranges;
+        status = "disabled";
+
+        display-controller@c901000 {
+            compatible = "qcom,msm8998-dpu";
+            reg = <0x0c901000 0x8f000>,
+                  <0x0c9a8e00 0xf0>,
+                  <0x0c9b0000 0x2008>,
+                  <0x0c9b8000 0x1040>;
+            reg-names = "mdp", "regdma", "vbif", "vbif_nrt";
+
+            clocks = <&mmcc MDSS_AHB_CLK>,
+                     <&mmcc MDSS_AXI_CLK>,
+                     <&mmcc MNOC_AHB_CLK>,
+                     <&mmcc MDSS_MDP_CLK>,
+                     <&mmcc MDSS_VSYNC_CLK>;
+            clock-names = "iface", "bus", "mnoc", "core", "vsync";
+
+            interrupt-parent = <&mdss>;
+            interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
+            operating-points-v2 = <&mdp_opp_table>;
+            power-domains = <&rpmpd MSM8998_VDDMX>;
+
+            ports {
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                port@0 {
+                    reg = <0>;
+                    dpu_intf1_out: endpoint {
+                        remote-endpoint = <&dsi0_in>;
+                    };
+                };
+
+                port@1 {
+                    reg = <1>;
+                    dpu_intf2_out: endpoint {
+                        remote-endpoint = <&dsi1_in>;
+                    };
+                };
+            };
+        };
+    };
+...