diff mbox series

[v4,4/4] arm64: dts: rockchip: add analog audio on Quartz64

Message ID 20210903231536.225540-5-frattaroli.nicolas@gmail.com
State New
Headers show
Series None | expand

Commit Message

Nicolas Frattaroli Sept. 3, 2021, 11:15 p.m. UTC
On the Quartz64 Model A, the I2S1 TDM controller is connected
to the rk817 codec in I2S mode. Enabling it and adding the
necessary simple-sound-card and codec nodes allows for analog
audio output on the PINE64 Quartz64 Model A SBC.

Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
---
 .../boot/dts/rockchip/rk3566-quartz64-a.dts   | 35 ++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

Comments

Chris Morgan Sept. 7, 2021, 1:40 p.m. UTC | #1
On Sat, Sep 04, 2021 at 01:15:36AM +0200, Nicolas Frattaroli wrote:
> On the Quartz64 Model A, the I2S1 TDM controller is connected

> to the rk817 codec in I2S mode. Enabling it and adding the

> necessary simple-sound-card and codec nodes allows for analog

> audio output on the PINE64 Quartz64 Model A SBC.

> 

> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>

> ---

>  .../boot/dts/rockchip/rk3566-quartz64-a.dts   | 35 ++++++++++++++++++-

>  1 file changed, 34 insertions(+), 1 deletion(-)

> 

> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts

> index a244f7b87e38..3a87c0240b30 100644

> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts

> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts

> @@ -58,6 +58,20 @@ led-diy {

>  		};

>  	};

>  

> +	rk817-sound {

> +		compatible = "simple-audio-card";

> +		simple-audio-card,format = "i2s";

> +		simple-audio-card,name = "Analog RK817";

> +		simple-audio-card,mclk-fs = <256>;

> +

> +		simple-audio-card,cpu {

> +			sound-dai = <&i2s1_8ch>;

> +		};

> +		simple-audio-card,codec {

> +			sound-dai = <&rk817>;

> +		};

> +	};

> +

>  	vcc12v_dcin: vcc12v_dcin {

>  		compatible = "regulator-fixed";

>  		regulator-name = "vcc12v_dcin";

> @@ -199,8 +213,13 @@ rk817: pmic@20 {

>  		interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;

>  		clock-output-names = "rk808-clkout1", "rk808-clkout2";

>  

> +		#sound-dai-cells = <0>;

> +		clock-names = "mclk";

> +		clocks = <&cru I2S1_MCLKOUT_TX>;

> +		assigned-clocks = <&cru I2S1_MCLKOUT_TX>;

> +		assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;

>  		pinctrl-names = "default";

> -		pinctrl-0 = <&pmic_int_l>;

> +		pinctrl-0 = <&pmic_int_l>, <&i2s1m0_mclk>;

>  		rockchip,system-power-controller;

>  		wakeup-source;

>  		#clock-cells = <1>;

> @@ -389,9 +408,23 @@ regulator-state-mem {

>  				};

>  			};

>  		};

> +

> +		rk817_codec: codec {


This node should be optional and can probably be removed. It's only
used when there are extra parameters to pass to the codec (such as 
rockchip,mic-in-differential). Leaving it in shouldn't hurt anything
though.

> +		};

> +

>  	};

>  };

>  

> +&i2s1_8ch {

> +	status = "okay";

> +	rockchip,trcm-sync-tx-only;

> +	pinctrl-names = "default";

> +	pinctrl-0 = <&i2s1m0_sclktx

> +		     &i2s1m0_lrcktx

> +		     &i2s1m0_sdi0

> +		     &i2s1m0_sdo0>;

> +};

> +

>  &mdio1 {

>  	rgmii_phy1: ethernet-phy@0 {

>  		compatible = "ethernet-phy-ieee802.3-c22";

> -- 

> 2.33.0

>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
index a244f7b87e38..3a87c0240b30 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
@@ -58,6 +58,20 @@  led-diy {
 		};
 	};
 
+	rk817-sound {
+		compatible = "simple-audio-card";
+		simple-audio-card,format = "i2s";
+		simple-audio-card,name = "Analog RK817";
+		simple-audio-card,mclk-fs = <256>;
+
+		simple-audio-card,cpu {
+			sound-dai = <&i2s1_8ch>;
+		};
+		simple-audio-card,codec {
+			sound-dai = <&rk817>;
+		};
+	};
+
 	vcc12v_dcin: vcc12v_dcin {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc12v_dcin";
@@ -199,8 +213,13 @@  rk817: pmic@20 {
 		interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
 		clock-output-names = "rk808-clkout1", "rk808-clkout2";
 
+		#sound-dai-cells = <0>;
+		clock-names = "mclk";
+		clocks = <&cru I2S1_MCLKOUT_TX>;
+		assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
+		assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
 		pinctrl-names = "default";
-		pinctrl-0 = <&pmic_int_l>;
+		pinctrl-0 = <&pmic_int_l>, <&i2s1m0_mclk>;
 		rockchip,system-power-controller;
 		wakeup-source;
 		#clock-cells = <1>;
@@ -389,9 +408,23 @@  regulator-state-mem {
 				};
 			};
 		};
+
+		rk817_codec: codec {
+		};
+
 	};
 };
 
+&i2s1_8ch {
+	status = "okay";
+	rockchip,trcm-sync-tx-only;
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2s1m0_sclktx
+		     &i2s1m0_lrcktx
+		     &i2s1m0_sdi0
+		     &i2s1m0_sdo0>;
+};
+
 &mdio1 {
 	rgmii_phy1: ethernet-phy@0 {
 		compatible = "ethernet-phy-ieee802.3-c22";