| Message ID | 20210904183014.43528-1-konrad.dybcio@somainline.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/9] dt-bindings: clk: qcom: Add bindings for MSM8994 GCC driver | expand |
On Sat, 04 Sep 2021 20:30:05 +0200, Konrad Dybcio wrote: > Add documentation for the MSM8994 GCC driver. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > --- > Changes since v2: > > - Dropped second dt-binding part for the weird SD card clock configuration > - Fix up many mistakes, including maintainers, license and order > - I still have no idea why I get a pinctrl regex error.. need help here! > > .../bindings/clock/qcom,gcc-msm8994.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.example.dt.yaml: clock-controller@300000: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/qcom,gcc.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1524636 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Quoting Konrad Dybcio (2021-09-04 11:30:05) > Add documentation for the MSM8994 GCC driver. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> > --- > Changes since v2: > > - Dropped second dt-binding part for the weird SD card clock configuration > - Fix up many mistakes, including maintainers, license and order > - I still have no idea why I get a pinctrl regex error.. need help here! The compatible fro gcc-msm8994 seems to already be documented in Documentation/devicetree/bindings/clock/qcom,gcc.yaml so it needs to be removed from there and only specified in this 8994 specific binding.
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.yaml new file mode 100644 index 000000000000..22e67b238bb6 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/qcom,gcc-msm8994.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Global Clock & Reset Controller Binding for MSM8994 + +maintainers: + - Konrad Dybcio <konrad.dybcio@somainline.org> + +description: | + Qualcomm global clock control module which supports the clocks, resets and + power domains on MSM8994 and MSM8992. + + See also: + - dt-bindings/clock/qcom,gcc-msm8994.h + +properties: + compatible: + enum: + - qcom,gcc-msm8992 + - qcom,gcc-msm8994 + + clocks: + items: + - description: Board XO source + - description: Sleep clock source + + clock-names: + items: + - const: xo + - const: sleep + + '#clock-cells': + const: 1 + + '#reset-cells': + const: 1 + + '#power-domain-cells': + const: 1 + + reg: + maxItems: 1 + +required: + - compatible + - clocks + - clock-names + - reg + - '#clock-cells' + - '#reset-cells' + - '#power-domain-cells' + +additionalProperties: false + +examples: + - | + clock-controller@300000 { + compatible = "qcom,gcc-msm8994"; + reg = <0x00300000 0x90000>; + clocks = <&xo_board>, <&sleep_clk>; + clock-names = "xo", "sleep"; + #clock-cells = <1>; + #reset-cells = <1>; + #power-domain-cells = <1>; + }; + +...
Add documentation for the MSM8994 GCC driver. Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> --- Changes since v2: - Dropped second dt-binding part for the weird SD card clock configuration - Fix up many mistakes, including maintainers, license and order - I still have no idea why I get a pinctrl regex error.. need help here! .../bindings/clock/qcom,gcc-msm8994.yaml | 70 +++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.yaml