| Message ID | 20210906083559.9109-1-nbd@nbd.name |
|---|---|
| State | New |
| Headers | show |
| Series | Revert "mac80211: do not use low data rates for data frames with no ack flag" | expand |
I confirm the revert fixes sending multicast frames on my ath9k device. -- Petr
diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c index e5935e3d7a07..8c6416129d5b 100644 --- a/net/mac80211/rate.c +++ b/net/mac80211/rate.c @@ -392,10 +392,6 @@ static bool rate_control_send_low(struct ieee80211_sta *pubsta, int mcast_rate; bool use_basicrate = false; - if (ieee80211_is_tx_data(txrc->skb) && - info->flags & IEEE80211_TX_CTL_NO_ACK) - return false; - if (!pubsta || rc_no_data_or_no_ack_use_min(txrc)) { __rate_control_send_low(txrc->hw, sband, pubsta, info, txrc->rate_idx_mask);
This reverts commit d333322361e7a099dc74df2498d3fa5fde5c4fa7. Returning false early in rate_control_send_low breaks sending broadcast packets, since rate control will not select a rate for it. Before re-introducing a fixed version of this patch, we should probably also make some changes to rate control to be more conservative in selecting rates for no-ack packets and also prevent using probing rates on them, since we won't get any feedback. Signed-off-by: Felix Fietkau <nbd@nbd.name> --- net/mac80211/rate.c | 4 ---- 1 file changed, 4 deletions(-)