diff mbox series

usb: typec: hd3ss3220: Use regmap_write_bits()

Message ID 20210907092706.31748-1-p.zabel@pengutronix.de
State New
Headers show
Series usb: typec: hd3ss3220: Use regmap_write_bits() | expand

Commit Message

Philipp Zabel Sept. 7, 2021, 9:27 a.m. UTC
Use the regmap_write_bits() macro instead of regmap_update_bits_base().
No functional change.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/usb/typec/hd3ss3220.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Heikki Krogerus Sept. 13, 2021, 11:48 a.m. UTC | #1
On Tue, Sep 07, 2021 at 11:27:06AM +0200, Philipp Zabel wrote:
> Use the regmap_write_bits() macro instead of regmap_update_bits_base().

> No functional change.

> 

> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>


Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>


> ---

>  drivers/usb/typec/hd3ss3220.c | 8 +++-----

>  1 file changed, 3 insertions(+), 5 deletions(-)

> 

> diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c

> index f633ec15b1a1..cd47c3597e19 100644

> --- a/drivers/usb/typec/hd3ss3220.c

> +++ b/drivers/usb/typec/hd3ss3220.c

> @@ -125,11 +125,9 @@ static irqreturn_t hd3ss3220_irq(struct hd3ss3220 *hd3ss3220)

>  	int err;

>  

>  	hd3ss3220_set_role(hd3ss3220);

> -	err = regmap_update_bits_base(hd3ss3220->regmap,

> -				      HD3SS3220_REG_CN_STAT_CTRL,

> -				      HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS,

> -				      HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS,

> -				      NULL, false, true);

> +	err = regmap_write_bits(hd3ss3220->regmap, HD3SS3220_REG_CN_STAT_CTRL,

> +				HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS,

> +				HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS);

>  	if (err < 0)

>  		return IRQ_NONE;

>  

> -- 

> 2.30.2


-- 
heikki
diff mbox series

Patch

diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
index f633ec15b1a1..cd47c3597e19 100644
--- a/drivers/usb/typec/hd3ss3220.c
+++ b/drivers/usb/typec/hd3ss3220.c
@@ -125,11 +125,9 @@  static irqreturn_t hd3ss3220_irq(struct hd3ss3220 *hd3ss3220)
 	int err;
 
 	hd3ss3220_set_role(hd3ss3220);
-	err = regmap_update_bits_base(hd3ss3220->regmap,
-				      HD3SS3220_REG_CN_STAT_CTRL,
-				      HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS,
-				      HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS,
-				      NULL, false, true);
+	err = regmap_write_bits(hd3ss3220->regmap, HD3SS3220_REG_CN_STAT_CTRL,
+				HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS,
+				HD3SS3220_REG_CN_STAT_CTRL_INT_STATUS);
 	if (err < 0)
 		return IRQ_NONE;