[05/15] nfc: pn533: drop unneeded debug prints

Message ID 20210907121816.37750-6-krzysztof.kozlowski@canonical.com
State New
Headers show
Series
  • nfc: minor printk cleanup
Related show

Commit Message

Krzysztof Kozlowski Sept. 7, 2021, 12:18 p.m.
ftrace is a preferred and standard way to debug entering and exiting
functions so drop useless debug prints.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/nfc/pn533/i2c.c   | 1 -
 drivers/nfc/pn533/pn533.c | 2 --
 2 files changed, 3 deletions(-)

Comments

Jakub Kicinski Sept. 7, 2021, 5:03 p.m. | #1
On Tue, 7 Sep 2021 18:05:25 +0200 Krzysztof Kozlowski wrote:
> On 07/09/2021 14:18, Krzysztof Kozlowski wrote:
> > ftrace is a preferred and standard way to debug entering and exiting
> > functions so drop useless debug prints.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > ---
> >  drivers/nfc/pn533/i2c.c   | 1 -
> >  drivers/nfc/pn533/pn533.c | 2 --
> >  2 files changed, 3 deletions(-)
> > 
> > diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c
> > index e6bf8cfe3aa7..91d4a035eb63 100644
> > --- a/drivers/nfc/pn533/i2c.c
> > +++ b/drivers/nfc/pn533/i2c.c
> > @@ -138,7 +138,6 @@ static irqreturn_t pn533_i2c_irq_thread_fn(int irq, void *data)
> >  	}
> >  
> >  	client = phy->i2c_dev;  
> 
> This line should also be removed (reported by kbuild robot).
> 
> I will send a v2.

Dave marked the series as Deferred (although this patch is Changes
Requested, I'm guessing you did that, if so please don't change patch
states in netdev pw), please hold off:


# Form letter - net-next is closed

We have already sent the networking pull request for 5.15
and therefore net-next is closed for new drivers, features,
code refactoring and optimizations. We are currently accepting
bug fixes only.

Please repost when net-next reopens after 5.15-rc1 is cut.

Look out for the announcement on the mailing list or check:
http://vger.kernel.org/~davem/net-next.html

RFC patches sent for review only are obviously welcome at any time.

Patch

diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c
index e6bf8cfe3aa7..91d4a035eb63 100644
--- a/drivers/nfc/pn533/i2c.c
+++ b/drivers/nfc/pn533/i2c.c
@@ -138,7 +138,6 @@  static irqreturn_t pn533_i2c_irq_thread_fn(int irq, void *data)
 	}
 
 	client = phy->i2c_dev;
-	dev_dbg(&client->dev, "IRQ\n");
 
 	if (phy->hard_fault != 0)
 		return IRQ_HANDLED;
diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c
index 2f3f3fe9a0ba..c5f127fe2d45 100644
--- a/drivers/nfc/pn533/pn533.c
+++ b/drivers/nfc/pn533/pn533.c
@@ -1235,8 +1235,6 @@  static void pn533_listen_mode_timer(struct timer_list *t)
 {
 	struct pn533 *dev = from_timer(dev, t, listen_timer);
 
-	dev_dbg(dev->dev, "Listen mode timeout\n");
-
 	dev->cancel_listen = 1;
 
 	pn533_poll_next_mod(dev);