| Message ID | 20210911232707.259615-7-luca@z3ntu.xyz |
|---|---|
| State | New |
| Headers | show |
| Series | [1/8] pinctrl: qcom: msm8226: fill in more functions | expand |
On 12/09/2021 01:27, Luca Weiss wrote: > LG Electronics is a part of the LG Corporation and produces, amongst > other things, consumer electronics such as phones and smartwatches. Hi, Thanks for the patches. I think "lge" it's the same prefix as "lg". There is no sense in having multiple vendor prefixes just because company splits inside business units or subsidiaries. The same as with other conglomerates, e.g. Samsung - if we wanted to be specific, there will be 4-5 Samsung vendors... Not mentioning that company organisation is not always disclosed and can change. We already have lg for several components, also made by LG Electronics. What about these? There is only one device with "lge", added back in 2016 without adding vendor prefix. I would propose to fix that one, instead of keeping duplicated "lg". Best regards, Krzysztof
Hi Krzysztof, On Montag, 13. September 2021 10:49:43 CEST Krzysztof Kozlowski wrote: > On 12/09/2021 01:27, Luca Weiss wrote: > > LG Electronics is a part of the LG Corporation and produces, amongst > > other things, consumer electronics such as phones and smartwatches. > > Hi, > > Thanks for the patches. > > I think "lge" it's the same prefix as "lg". There is no sense in having > multiple vendor prefixes just because company splits inside business > units or subsidiaries. The same as with other conglomerates, e.g. > Samsung - if we wanted to be specific, there will be 4-5 Samsung > vendors... Not mentioning that company organisation is not always > disclosed and can change. > I was mostly following qcom-msm8974-lge-nexus5-hammerhead as it's the other LG device tree I am aware of so I've picked lge instead of lg. Also worth noting that Google uses "LGE" in the Android device tree[1] or in the model name in the LG G Watch R kernel sources ("LGE APQ 8026v2 LENOK rev-1.0"). I don't have a strong opinion either way so I'm fine with either. If we decide to go with "lg" do we want to change the Nexus 5 devicetree (hammerhead) also, that one has the lge name in at least compatible and filename (I don't know how much of a breaking change that would be considered as). > We already have lg for several components, also made by LG Electronics. > What about these? > > There is only one device with "lge", added back in 2016 without adding > vendor prefix. I would propose to fix that one, instead of keeping > duplicated "lg". > > Best regards, > Krzysztof Regards Luca [1] https://android.googlesource.com/device/lge/hammerhead/
On 13/09/2021 21:14, Luca Weiss wrote: > Hi Krzysztof, > > On Montag, 13. September 2021 10:49:43 CEST Krzysztof Kozlowski wrote: >> On 12/09/2021 01:27, Luca Weiss wrote: >>> LG Electronics is a part of the LG Corporation and produces, amongst >>> other things, consumer electronics such as phones and smartwatches. >> >> Hi, >> >> Thanks for the patches. >> >> I think "lge" it's the same prefix as "lg". There is no sense in having >> multiple vendor prefixes just because company splits inside business >> units or subsidiaries. The same as with other conglomerates, e.g. >> Samsung - if we wanted to be specific, there will be 4-5 Samsung >> vendors... Not mentioning that company organisation is not always >> disclosed and can change. >> > > I was mostly following qcom-msm8974-lge-nexus5-hammerhead as it's the other LG > device tree I am aware of so I've picked lge instead of lg. Also worth noting > that Google uses "LGE" in the Android device tree[1] or in the model name in > the LG G Watch R kernel sources ("LGE APQ 8026v2 LENOK rev-1.0") [1] Does not point to kernel tree. Downstream user could be a good argument to switch to lge, but then I would expect correcting other "lg" devices which are in fact made by LGE. > > I don't have a strong opinion either way so I'm fine with either. > > If we decide to go with "lg" do we want to change the Nexus 5 devicetree > (hammerhead) also, that one has the lge name in at least compatible and > filename (I don't know how much of a breaking change that would be considered > as). We would have to add a new one and mark the old compatible as deprecated. > >> We already have lg for several components, also made by LG Electronics. >> What about these? >> >> There is only one device with "lge", added back in 2016 without adding >> vendor prefix. I would propose to fix that one, instead of keeping >> duplicated "lg". >> >> Best regards, >> Krzysztof > > Regards > Luca > > [1] https://android.googlesource.com/device/lge/hammerhead/ > > > Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index a867f7102c35..b99af98bf5de 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -635,6 +635,8 @@ patternProperties: description: Lenovo Group Ltd. "^lg,.*": description: LG Corporation + "^lge,.*": + description: LG Electronics Inc. "^lgphilips,.*": description: LG Display "^libretech,.*":
LG Electronics is a part of the LG Corporation and produces, amongst other things, consumer electronics such as phones and smartwatches. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)