net: atl1c: Make use of the helper function dev_err_probe()

Message ID 20210915145749.7251-1-caihuoqing@baidu.com
State New
Headers show
Series
  • net: atl1c: Make use of the helper function dev_err_probe()
Related show

Commit Message

Cai,Huoqing Sept. 15, 2021, 2:57 p.m.
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 16, 2021, 12:40 p.m. | #1
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 15 Sep 2021 22:57:48 +0800 you wrote:
> When possible use dev_err_probe help to properly deal with the

> PROBE_DEFER error, the benefit is that DEFER issue will be logged

> in the devices_deferred debugfs file.

> And using dev_err_probe() can reduce code size, and simplify the code.

> 

> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

> 

> [...]


Here is the summary with links:
  - net: atl1c: Make use of the helper function dev_err_probe()
    https://git.kernel.org/netdev/net-next/c/d502933c30c6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Patch

diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 3b51b172b317..20c032ab631b 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -2662,10 +2662,8 @@  static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	/* enable device (incl. PCI PM wakeup and hotplug setup) */
 	err = pci_enable_device_mem(pdev);
-	if (err) {
-		dev_err(&pdev->dev, "cannot enable PCI device\n");
-		return err;
-	}
+	if (err)
+		return dev_err_probe(&pdev->dev, err, "cannot enable PCI device\n");
 
 	/*
 	 * The atl1c chip can DMA to 64-bit addresses, but it uses a single