diff mbox series

arm64: dts: ls1028a: fix eSDHC2 node

Message ID 20210915202259.3000923-1-michael@walle.cc
State Accepted
Commit 8b94aa318aa746fbbc668d6b9b3ad812c835230c
Headers show
Series arm64: dts: ls1028a: fix eSDHC2 node | expand

Commit Message

Michael Walle Sept. 15, 2021, 8:22 p.m. UTC
On the LS1028A this instance of the eSDHC controller is intended for
either an eMMC or eSDIO card. It doesn't provide a card detect pin and
its IO voltage is fixed at 1.8V.

Remove the bogus broken-cd property, instead add the non-removable
property. Fix the voltage-ranges property and set it to 1.8V only.

Fixes: 491d3a3fc113 ("arm64: dts: ls1028a: Add esdhc node in dts")
Signed-off-by: Michael Walle <michael@walle.cc>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Shawn Guo Oct. 4, 2021, 12:42 p.m. UTC | #1
On Wed, Sep 15, 2021 at 10:22:59PM +0200, Michael Walle wrote:
> On the LS1028A this instance of the eSDHC controller is intended for

> either an eMMC or eSDIO card. It doesn't provide a card detect pin and

> its IO voltage is fixed at 1.8V.

> 

> Remove the bogus broken-cd property, instead add the non-removable

> property. Fix the voltage-ranges property and set it to 1.8V only.

> 

> Fixes: 491d3a3fc113 ("arm64: dts: ls1028a: Add esdhc node in dts")

> Signed-off-by: Michael Walle <michael@walle.cc>


Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index ef771bfad11c..8cee1f79e5c0 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -407,9 +407,9 @@  esdhc1: mmc@2150000 {
 			interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
 			clock-frequency = <0>; /* fixed up by bootloader */
 			clocks = <&clockgen QORIQ_CLK_HWACCEL 1>;
-			voltage-ranges = <1800 1800 3300 3300>;
+			voltage-ranges = <1800 1800>;
 			sdhci,auto-cmd12;
-			broken-cd;
+			non-removable;
 			little-endian;
 			bus-width = <4>;
 			status = "disabled";