| Message ID | 20210916153233.14363-1-caihuoqing@baidu.com |
|---|---|
| State | New |
| Headers | show |
| Series | Input: ilitek_ts_i2c - Make use of the helper function dev_err_probe() | expand |
diff --git a/drivers/input/touchscreen/ilitek_ts_i2c.c b/drivers/input/touchscreen/ilitek_ts_i2c.c index c5d259c76adc..a113d74b6ddc 100644 --- a/drivers/input/touchscreen/ilitek_ts_i2c.c +++ b/drivers/input/touchscreen/ilitek_ts_i2c.c @@ -562,11 +562,9 @@ static int ilitek_ts_i2c_probe(struct i2c_client *client, i2c_set_clientdata(client, ts); ts->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(ts->reset_gpio)) { - error = PTR_ERR(ts->reset_gpio); - dev_err(dev, "request gpiod failed: %d", error); - return error; - } + if (IS_ERR(ts->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(ts->reset_gpio), + "request gpiod failed"); ilitek_reset(ts, 1000);
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/input/touchscreen/ilitek_ts_i2c.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)