| Message ID | 20210916153104.13727-1-caihuoqing@baidu.com |
|---|---|
| State | New |
| Headers | show |
| Series | Input: ads7846 - Make use of the helper function dev_err_probe() | expand |
On 16 9月 21 21:34:26, Krzysztof Kozlowski wrote: > On 16/09/2021 17:31, Cai Huoqing wrote: > > When possible use dev_err_probe help to properly deal with the > > PROBE_DEFER error, the benefit is that DEFER issue will be logged > > in the devices_deferred debugfs file. > > Using dev_err_probe() can reduce code size, and the error value > > gets printed. > > > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > > --- > > drivers/input/touchscreen/ads7846.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > You sent 32 independent patches. Do you expect us to copy-paste similar > feedback on each of them? This would not make any sense. Please organize > all your submissions in a series with: > > git format-patch -32 > git send-email ..... 00* Ok, I'll try. but there are different owners for touchscreen/xxx, is it ok to send them the whole series? > > The patches you sent were already sent before: > https://lore.kernel.org/lkml/20200827185829.30096-1-krzk@kernel.org/ > > Best regards, > Krzysztof
On 17/09/2021 04:29, Cai Huoqing wrote: > On 16 9月 21 21:34:26, Krzysztof Kozlowski wrote: >> On 16/09/2021 17:31, Cai Huoqing wrote: >>> When possible use dev_err_probe help to properly deal with the >>> PROBE_DEFER error, the benefit is that DEFER issue will be logged >>> in the devices_deferred debugfs file. >>> Using dev_err_probe() can reduce code size, and the error value >>> gets printed. >>> >>> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> >>> --- >>> drivers/input/touchscreen/ads7846.c | 7 ++----- >>> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> You sent 32 independent patches. Do you expect us to copy-paste similar >> feedback on each of them? This would not make any sense. Please organize >> all your submissions in a series with: >> >> git format-patch -32 >> git send-email ..... 00* > Ok, I'll try. but there are different owners for touchscreen/xxx, > is it ok to send them the whole series? I see the same maintainers: Dmitry Torokhov + linux-input HWMON also appears because of usage of hwmon API inside, which might happen anyway for few other input drivers Best regards, Krzysztof
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index eaa8714ad19d..f5c053940cbf 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c @@ -1337,11 +1337,8 @@ static int ads7846_probe(struct spi_device *spi) ads7846_setup_spi_msg(ts, pdata); ts->reg = devm_regulator_get(dev, "vcc"); - if (IS_ERR(ts->reg)) { - err = PTR_ERR(ts->reg); - dev_err(dev, "unable to get regulator: %d\n", err); - return err; - } + if (IS_ERR(ts->reg)) + return dev_err_probe(dev, PTR_ERR(ts->reg), "unable to get regulator\n"); err = regulator_enable(ts->reg); if (err) {
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/input/touchscreen/ads7846.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)