| Message ID | 1437551743-20599-2-git-send-email-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | 31115336d95d7d9ebb4b1bb8449876f798b0b2f7 |
| Headers | show |
On Wed, 22 Jul 2015, Linus Walleij wrote: > There is a special function for debug prints rather than the > usual hexdump function, let's use it. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/mfd/ipaq-micro.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c > index 99bc2e844c29..9bfe2462c5c5 100644 > --- a/drivers/mfd/ipaq-micro.c > +++ b/drivers/mfd/ipaq-micro.c > @@ -53,8 +53,8 @@ static void ipaq_micro_trigger_tx(struct ipaq_micro *micro) > tx->buf[bp++] = checksum; > tx->len = bp; > tx->index = 0; > - print_hex_dump(KERN_DEBUG, "data: ", DUMP_PREFIX_OFFSET, 16, 1, > - tx->buf, tx->len, true); > + print_hex_dump_debug("data: ", DUMP_PREFIX_OFFSET, 16, 1, > + tx->buf, tx->len, true); > > /* Enable interrupt */ > val = readl(micro->base + UTCR3); > @@ -281,8 +281,8 @@ static void ipaq_micro_eeprom_dump(struct ipaq_micro *micro) > dev_info(micro->dev, "RAM size: %u KiB\n", ipaq_micro_to_u16(dump+92)); > dev_info(micro->dev, "screen: %u x %u\n", > ipaq_micro_to_u16(dump+94), ipaq_micro_to_u16(dump+96)); > - print_hex_dump(KERN_DEBUG, "eeprom: ", DUMP_PREFIX_OFFSET, 16, 1, > - dump, 256, true); > + print_hex_dump_debug("eeprom: ", DUMP_PREFIX_OFFSET, 16, 1, > + dump, 256, true); > > } >
diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c index 99bc2e844c29..9bfe2462c5c5 100644 --- a/drivers/mfd/ipaq-micro.c +++ b/drivers/mfd/ipaq-micro.c @@ -53,8 +53,8 @@ static void ipaq_micro_trigger_tx(struct ipaq_micro *micro) tx->buf[bp++] = checksum; tx->len = bp; tx->index = 0; - print_hex_dump(KERN_DEBUG, "data: ", DUMP_PREFIX_OFFSET, 16, 1, - tx->buf, tx->len, true); + print_hex_dump_debug("data: ", DUMP_PREFIX_OFFSET, 16, 1, + tx->buf, tx->len, true); /* Enable interrupt */ val = readl(micro->base + UTCR3); @@ -281,8 +281,8 @@ static void ipaq_micro_eeprom_dump(struct ipaq_micro *micro) dev_info(micro->dev, "RAM size: %u KiB\n", ipaq_micro_to_u16(dump+92)); dev_info(micro->dev, "screen: %u x %u\n", ipaq_micro_to_u16(dump+94), ipaq_micro_to_u16(dump+96)); - print_hex_dump(KERN_DEBUG, "eeprom: ", DUMP_PREFIX_OFFSET, 16, 1, - dump, 256, true); + print_hex_dump_debug("eeprom: ", DUMP_PREFIX_OFFSET, 16, 1, + dump, 256, true); }
There is a special function for debug prints rather than the usual hexdump function, let's use it. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/mfd/ipaq-micro.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)