| Message ID | 20210916170511.137915-1-krzysztof.kozlowski@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: sdhci-s3c: drop unneeded MODULE_ALIAS | expand |
On 9/17/21 2:05 AM, Krzysztof Kozlowski wrote: > The MODULE_DEVICE_TABLE already creates proper alias for platform > driver. Having another MODULE_ALIAS causes the alias to be duplicated. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsunhg.com> Best Regards, Jaehoon Chung > --- > drivers/mmc/host/sdhci-s3c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index 862f033d235d..9085f3932443 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -791,4 +791,3 @@ module_platform_driver(sdhci_s3c_driver); > MODULE_DESCRIPTION("Samsung SDHCI (HSMMC) glue"); > MODULE_AUTHOR("Ben Dooks, <ben@simtec.co.uk>"); > MODULE_LICENSE("GPL v2"); > -MODULE_ALIAS("platform:s3c-sdhci"); >
On Thu, 16 Sept 2021 at 19:05, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > The MODULE_DEVICE_TABLE already creates proper alias for platform > driver. Having another MODULE_ALIAS causes the alias to be duplicated. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-s3c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index 862f033d235d..9085f3932443 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -791,4 +791,3 @@ module_platform_driver(sdhci_s3c_driver); > MODULE_DESCRIPTION("Samsung SDHCI (HSMMC) glue"); > MODULE_AUTHOR("Ben Dooks, <ben@simtec.co.uk>"); > MODULE_LICENSE("GPL v2"); > -MODULE_ALIAS("platform:s3c-sdhci"); > -- > 2.30.2 >
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 862f033d235d..9085f3932443 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -791,4 +791,3 @@ module_platform_driver(sdhci_s3c_driver); MODULE_DESCRIPTION("Samsung SDHCI (HSMMC) glue"); MODULE_AUTHOR("Ben Dooks, <ben@simtec.co.uk>"); MODULE_LICENSE("GPL v2"); -MODULE_ALIAS("platform:s3c-sdhci");
The MODULE_DEVICE_TABLE already creates proper alias for platform driver. Having another MODULE_ALIAS causes the alias to be duplicated. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- drivers/mmc/host/sdhci-s3c.c | 1 - 1 file changed, 1 deletion(-)