diff mbox series

drm/tegra: mark nvdec_writel as inline

Message ID 20211013144109.2191071-1-arnd@kernel.org
State New
Headers show
Series drm/tegra: mark nvdec_writel as inline | expand

Commit Message

Arnd Bergmann Oct. 13, 2021, 2:40 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de>


Without CONFIG_IOMMU_API, the nvdec_writel() function is
unused, causing a warning:

drivers/gpu/drm/tegra/nvdec.c:48:13: error: 'nvdec_writel' defined but not used [-Werror=unused-function]
   48 | static void nvdec_writel(struct nvdec *nvdec, u32 value, unsigned int offset)
      |             ^~~~~~~~~~~~

As this is a trivial wrapper around an inline function, mark
it as inline itself, which avoids the warning as well.

Fixes: e76599df354d ("drm/tegra: Add NVDEC driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/gpu/drm/tegra/nvdec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.29.2

Comments

Thierry Reding Oct. 18, 2021, 1:56 p.m. UTC | #1
On Wed, Oct 13, 2021 at 04:40:58PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>

> 

> Without CONFIG_IOMMU_API, the nvdec_writel() function is

> unused, causing a warning:

> 

> drivers/gpu/drm/tegra/nvdec.c:48:13: error: 'nvdec_writel' defined but not used [-Werror=unused-function]

>    48 | static void nvdec_writel(struct nvdec *nvdec, u32 value, unsigned int offset)

>       |             ^~~~~~~~~~~~

> 

> As this is a trivial wrapper around an inline function, mark

> it as inline itself, which avoids the warning as well.

> 

> Fixes: e76599df354d ("drm/tegra: Add NVDEC driver")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  drivers/gpu/drm/tegra/nvdec.c | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)


Applied, thanks.

Thierry
diff mbox series

Patch

diff --git a/drivers/gpu/drm/tegra/nvdec.c b/drivers/gpu/drm/tegra/nvdec.c
index 410333e05de8..791bf1acf5f0 100644
--- a/drivers/gpu/drm/tegra/nvdec.c
+++ b/drivers/gpu/drm/tegra/nvdec.c
@@ -45,7 +45,8 @@  static inline struct nvdec *to_nvdec(struct tegra_drm_client *client)
 	return container_of(client, struct nvdec, client);
 }
 
-static void nvdec_writel(struct nvdec *nvdec, u32 value, unsigned int offset)
+static inline void nvdec_writel(struct nvdec *nvdec, u32 value,
+				unsigned int offset)
 {
 	writel(value, nvdec->regs + offset);
 }