diff mbox series

[v1,3/9] pinctrl: apple: handle regmap_read errors

Message ID 20211113162944.22412-4-joey.gouly@arm.com
State New
Headers show
Series [v1,1/9] pinctrl: apple: fix some formatting issues | expand

Commit Message

Joey Gouly Nov. 13, 2021, 4:29 p.m. UTC 
Explicitly return 0 if the regmap_read fails.

Signed-off-by: Joey Gouly <joey.gouly@arm.com>
---
 drivers/pinctrl/pinctrl-apple-gpio.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c
index 4f7fb79d8e11..bd7f28150ac0 100644
--- a/drivers/pinctrl/pinctrl-apple-gpio.c
+++ b/drivers/pinctrl/pinctrl-apple-gpio.c
@@ -84,9 +84,13 @@  static void apple_gpio_set_reg(struct apple_gpio_pinctrl *pctl,
 static u32 apple_gpio_get_reg(struct apple_gpio_pinctrl *pctl,
                               unsigned int pin)
 {
-	unsigned int val = 0;
+	int ret;
+	u32 val;
+
+	ret = regmap_read(pctl->map, REG_GPIO(pin), &val);
+	if (ret)
+		return 0;
 
-	regmap_read(pctl->map, REG_GPIO(pin), &val);
 	return val;
 }