| Message ID | 20211115203459.1634079-7-marijn.suijten@somainline.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | backlight: qcom-wled: fix and solidify handling of enabled-strings | expand |
On Mon, 15 Nov 2021, Marijn Suijten wrote: > The previous commit improves num_strings parsing to not go over the > maximum of 3 strings for WLED3 anymore. Likewise this default index for > a hypothetical 4th string is invalid and could access registers that are > not mapped to the desired purpose. > Removing this value gets rid of undesired confusion and avoids the > possibility of accessing registers at this offset even if the 4th array > element is used by accident. > > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > drivers/video/backlight/qcom-wled.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks.
diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 5306b06044b4..5c5df5a3deab 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -948,7 +948,7 @@ static const struct wled_config wled3_config_defaults = { .cs_out_en = false, .ext_gen = false, .cabc = false, - .enabled_strings = {0, 1, 2, 3}, + .enabled_strings = {0, 1, 2}, }; static int wled4_setup(struct wled *wled)