| Message ID | 1637584252-15617-1-git-send-email-loic.poulain@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] lib/circbuf: Make circbuf selectable symbol | expand |
Dear Loic Poulain, In message <1637584252-15617-1-git-send-email-loic.poulain@linaro.org> you wrote: > It is currenly only used from usbtty driver but make it properly > selectable via Kconfig symbol, for future usage. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > --- > v2: no change > > lib/Kconfig | 3 +++ > lib/Makefile | 8 +++++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/lib/Kconfig b/lib/Kconfig > index c535147..1bd54d8 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -290,6 +290,9 @@ config TRACE_EARLY_ADDR > the size is too small then the message which says the amount of early > data being coped will the the same as the > > +config CIRCBUF > + bool > + > source lib/dhry/Kconfig Please add a description what this symbos is doing. Thanks. Wolfgang Denk
Hi Wolfgang, On Mon, 22 Nov 2021 at 13:50, Wolfgang Denk <wd@denx.de> wrote: > > Dear Loic Poulain, > > In message <1637584252-15617-1-git-send-email-loic.poulain@linaro.org> you wrote: > > It is currenly only used from usbtty driver but make it properly > > selectable via Kconfig symbol, for future usage. > > > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > > --- > > v2: no change > > > > lib/Kconfig | 3 +++ > > lib/Makefile | 8 +++++++- > > 2 files changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/lib/Kconfig b/lib/Kconfig > > index c535147..1bd54d8 100644 > > --- a/lib/Kconfig > > +++ b/lib/Kconfig > > @@ -290,6 +290,9 @@ config TRACE_EARLY_ADDR > > the size is too small then the message which says the amount of early > > data being coped will the the same as the > > > > +config CIRCBUF > > + bool > > + > > source lib/dhry/Kconfig > > Please add a description what this symbos is doing. It's not a user selectable symbol, adding description will break that, right? Regards, Loic
diff --git a/lib/Kconfig b/lib/Kconfig index c535147..1bd54d8 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -290,6 +290,9 @@ config TRACE_EARLY_ADDR the size is too small then the message which says the amount of early data being coped will the the same as the +config CIRCBUF + bool + source lib/dhry/Kconfig menu "Security support" diff --git a/lib/Makefile b/lib/Makefile index 8ba745f..4daeee2 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -29,7 +29,13 @@ ifneq ($(CONFIG_CHARSET),) obj-y += charset.o endif endif -obj-$(CONFIG_USB_TTY) += circbuf.o + +ifdef CONFIG_USB_TTY +obj-y += circbuf.o +else +obj-$(CONFIG_CIRCBUF) += circbuf.o +endif + obj-y += crc8.o obj-y += crc16.o obj-$(CONFIG_ERRNO_STR) += errno_str.o
It is currenly only used from usbtty driver but make it properly selectable via Kconfig symbol, for future usage. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> --- v2: no change lib/Kconfig | 3 +++ lib/Makefile | 8 +++++++- 2 files changed, 10 insertions(+), 1 deletion(-)