| Message ID | 20211201231832.188634-1-virgule@jeanthomas.me |
|---|---|
| State | Accepted |
| Commit | 3f99518c6f6520ad0fd14d862d54ee12f16156b4 |
| Headers | show |
| Series | [v2,1/2] arm64: dts: msm8992-lg-bullhead: Place LG Bullhead generic code into a DTSI file | expand |
Hi Jean, > This patch puts the generic code common across all hardware revisions > into a DTSI file. > It also prefixes the DTS filename with the vendor name, to follow the > naming convention used by other DTS files. > Changes since v1: > - Added "model" property to the DTS file Not sure if model should stay also in msm8992-lg-bullhead.dtsi, probably yes. Reviewed-by: Petr Vorel <petr.vorel@gmail.com> Kind regards, Petr
Hi Jean, also for next time, also "qcom:" should be in subject (very minor). Kind regards, Petr
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 6b816eb33309..3617157f1420 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -17,7 +17,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a3u-eur.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a5u-eur.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb -dtb-$(CONFIG_ARCH_QCOM) += msm8992-bullhead-rev-101.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-101.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8992-msft-lumia-octagon-talkman.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8992-xiaomi-libra.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8994-angler-rev-101.dtb diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts new file mode 100644 index 000000000000..bcda7dbec6a4 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts @@ -0,0 +1,14 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* Copyright (c) Jean Thomas <virgule@jeanthomas.me> + */ + +/dts-v1/; + +#include "msm8992-lg-bullhead.dtsi" + +/ { + model = "LG Nexus 5X rev 1.01"; + + /* required for bootloader to select correct board */ + qcom,board-id = <0xb64 0>; +}; diff --git a/arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi similarity index 98% rename from arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts rename to arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi index 4da6c44bf532..3b0cc85d6674 100644 --- a/arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi @@ -18,9 +18,7 @@ / { compatible = "lg,bullhead", "qcom,msm8992"; chassis-type = "handset"; - /* required for bootloader to select correct board */ qcom,msm-id = <251 0>, <252 0>; - qcom,board-id = <0xb64 0>; qcom,pmic-id = <0x10009 0x1000A 0x0 0x0>; /* Bullhead firmware doesn't support PSCI */
This patch puts the generic code common across all hardware revisions into a DTSI file. It also prefixes the DTS filename with the vendor name, to follow the naming convention used by other DTS files. Changes since v1: - Added "model" property to the DTS file Signed-off-by: Jean THOMAS <virgule@jeanthomas.me> --- arch/arm64/boot/dts/qcom/Makefile | 2 +- .../boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts | 14 ++++++++++++++ ...llhead-rev-101.dts => msm8992-lg-bullhead.dtsi} | 2 -- 3 files changed, 15 insertions(+), 3 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dts rename arch/arm64/boot/dts/qcom/{msm8992-bullhead-rev-101.dts => msm8992-lg-bullhead.dtsi} (98%)