| Message ID | 009c6c2bc8436f38de85e125cdd7157f1b21a2cf.1638473687.git.lorenzo@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | mt76: mt7663: disable 4addr capability | expand |
On 2021-12-02 20:35, Lorenzo Bianconi wrote: > 4addr is not supported by the driver/firmware yet > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > --- > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c > index 47f23ac905a3..52182ab6d240 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c > @@ -378,6 +378,7 @@ mt7615_init_wiphy(struct ieee80211_hw *hw) > if (is_mt7663(&phy->dev->mt76)) { > wiphy->iface_combinations = if_comb; > wiphy->n_iface_combinations = ARRAY_SIZE(if_comb); > + wiphy->flags &= ~WIPHY_FLAG_4ADDR_STATION; Shouldn't this be done for the offload firmware only? - Felix
> > On 2021-12-02 20:35, Lorenzo Bianconi wrote: > > 4addr is not supported by the driver/firmware yet > > > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > > --- > > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c > > index 47f23ac905a3..52182ab6d240 100644 > > --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c > > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c > > @@ -378,6 +378,7 @@ mt7615_init_wiphy(struct ieee80211_hw *hw) > > if (is_mt7663(&phy->dev->mt76)) { > > wiphy->iface_combinations = if_comb; > > wiphy->n_iface_combinations = ARRAY_SIZE(if_comb); > > + wiphy->flags &= ~WIPHY_FLAG_4ADDR_STATION; > Shouldn't this be done for the offload firmware only? > > - Felix ack, right, I did not think about this combination. I tested with non-offload fw and it works. I will post v2 to fix it. Regards, Lorenzo
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c index 47f23ac905a3..52182ab6d240 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c @@ -378,6 +378,7 @@ mt7615_init_wiphy(struct ieee80211_hw *hw) if (is_mt7663(&phy->dev->mt76)) { wiphy->iface_combinations = if_comb; wiphy->n_iface_combinations = ARRAY_SIZE(if_comb); + wiphy->flags &= ~WIPHY_FLAG_4ADDR_STATION; } else { wiphy->iface_combinations = if_comb_radar; wiphy->n_iface_combinations = ARRAY_SIZE(if_comb_radar);
4addr is not supported by the driver/firmware yet Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> --- drivers/net/wireless/mediatek/mt76/mt7615/init.c | 1 + 1 file changed, 1 insertion(+)