| Message ID | 20211203212810.2666508-1-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Commit | 7d0c009043f6a970f62dbf5aecda9f8c3ccafcff |
| Headers | show |
| Series | platform/x86/intel: hid: add quirk to support Surface Go 3 | expand |
Hi, On 12/3/21 22:28, Alex Hung wrote: > Similar to other systems Surface Go 3 requires a DMI quirk to enable > 5 button array for power and volume buttons. > > Buglink: https://github.com/linux-surface/linux-surface/issues/595 > > Cc: stable@vger.kernel.org > Signed-off-by: Alex Hung <alex.hung@canonical.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. I will also include this in my next fixes pull-req for 5.16. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/intel/hid.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c > index 08598942a6d7..13f8cf70b9ae 100644 > --- a/drivers/platform/x86/intel/hid.c > +++ b/drivers/platform/x86/intel/hid.c > @@ -99,6 +99,13 @@ static const struct dmi_system_id button_array_table[] = { > DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Tablet Gen 2"), > }, > }, > + { > + .ident = "Microsoft Surface Go 3", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go 3"), > + }, > + }, > { } > }; > >
diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c index 08598942a6d7..13f8cf70b9ae 100644 --- a/drivers/platform/x86/intel/hid.c +++ b/drivers/platform/x86/intel/hid.c @@ -99,6 +99,13 @@ static const struct dmi_system_id button_array_table[] = { DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Tablet Gen 2"), }, }, + { + .ident = "Microsoft Surface Go 3", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"), + DMI_MATCH(DMI_PRODUCT_NAME, "Surface Go 3"), + }, + }, { } };
Similar to other systems Surface Go 3 requires a DMI quirk to enable 5 button array for power and volume buttons. Buglink: https://github.com/linux-surface/linux-surface/issues/595 Cc: stable@vger.kernel.org Signed-off-by: Alex Hung <alex.hung@canonical.com> --- drivers/platform/x86/intel/hid.c | 7 +++++++ 1 file changed, 7 insertions(+)