diff mbox series

[2/4] HID: bigbenff: prevent null pointer dereference

Message ID 20211202095334.14399-3-benjamin.tissoires@redhat.com
State Accepted
Commit 918aa1ef104d286d16b9e7ef139a463ac7a296f0
Headers show
Series HID: followup of uhid crashes, and couple of core | expand

Commit Message

Benjamin Tissoires Dec. 2, 2021, 9:53 a.m. UTC 
When emulating the device through uhid, there is a chance we don't have
output reports and so report_field is null.

Cc: stable@vger.kernel.org
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
 drivers/hid/hid-bigbenff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/hid/hid-bigbenff.c b/drivers/hid/hid-bigbenff.c
index db6da21ade06..74ad8bf98bfd 100644
--- a/drivers/hid/hid-bigbenff.c
+++ b/drivers/hid/hid-bigbenff.c
@@ -191,7 +191,7 @@  static void bigben_worker(struct work_struct *work)
 		struct bigben_device, worker);
 	struct hid_field *report_field = bigben->report->field[0];
 
-	if (bigben->removed)
+	if (bigben->removed || !report_field)
 		return;
 
 	if (bigben->work_led) {