[1/5] DFU: Do not copy the entity name over the buffer size

Message ID	163876947800.38238.12205367138412196203.stgit@localhost
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; From: Masami Hiramatsu <masami.hiramatsu@linaro.org> To: Lukasz Majewski <lukma@denx.de> Cc: u-boot@lists.denx.de, ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, jaswinder.singh@linaro.org Subject: [PATCH 1/5] DFU: Do not copy the entity name over the buffer size Date: Mon, 6 Dec 2021 14:44:38 +0900 Message-Id: <163876947800.38238.12205367138412196203.stgit@localhost> In-Reply-To: <163876946986.38238.10896882043017582609.stgit@localhost> References: <163876946986.38238.10896882043017582609.stgit@localhost> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: list Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	DFU: Update dfu_alt_info parser etc. \| expand [0/5] DFU: Update dfu_alt_info parser etc. [1/5] DFU: Do not copy the entity name over the buffer size [2/5] DFU: Accept redundant spaces and tabs in dfu_alt_info [3/5] DFU: Check the number of arguments and argument string strictly [4/5] doc: usage: DFU: Fix dfu_alt_info document [5/5] cmd/dfu: Enable 'dfu list' command without DFU_OVER_USB

Message ID

163876947800.38238.12205367138412196203.stgit@localhost

State

Superseded

Headers

Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de
 designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61;
From: Masami Hiramatsu <masami.hiramatsu@linaro.org>
To: Lukasz Majewski <lukma@denx.de>
Cc: u-boot@lists.denx.de, ilias.apalodimas@linaro.org,
 sughosh.ganu@linaro.org,
 jaswinder.singh@linaro.org
Subject: [PATCH 1/5] DFU: Do not copy the entity name over the buffer size
Date: Mon,  6 Dec 2021 14:44:38 +0900
Message-Id: <163876947800.38238.12205367138412196203.stgit@localhost>
In-Reply-To: <163876946986.38238.10896882043017582609.stgit@localhost>
References: <163876946986.38238.10896882043017582609.stgit@localhost>
User-Agent: StGit/0.19
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

DFU: Update dfu_alt_info parser etc. | expand

Use strlcpy() instead of strcpy() to prevent copying the entity name over the name buffer size. Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org> --- drivers/dfu/dfu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ilias Apalodimas Jan. 3, 2022, 7:40 a.m. UTC | #1

On Mon, 6 Dec 2021 at 07:44, Masami Hiramatsu
<masami.hiramatsu@linaro.org> wrote:
>
> Use strlcpy() instead of strcpy() to prevent copying the
> entity name over the name buffer size.
>
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> ---
>  drivers/dfu/dfu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
> index af3975925a..66c41b5e76 100644
> --- a/drivers/dfu/dfu.c
> +++ b/drivers/dfu/dfu.c
> @@ -503,7 +503,7 @@ static int dfu_fill_entity(struct dfu_entity *dfu, char *s, int alt,
>
>         debug("%s: %s interface: %s dev: %s\n", __func__, s, interface, devstr);
>         st = strsep(&s, " ");
> -       strcpy(dfu->name, st);
> +       strlcpy(dfu->name, st, DFU_NAME_SIZE);
>
>         dfu->alt = alt;
>         dfu->max_buf_size = 0;
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
index af3975925a..66c41b5e76 100644
--- a/drivers/dfu/dfu.c
+++ b/drivers/dfu/dfu.c
@@ -503,7 +503,7 @@  static int dfu_fill_entity(struct dfu_entity *dfu, char *s, int alt,
 
 	debug("%s: %s interface: %s dev: %s\n", __func__, s, interface, devstr);
 	st = strsep(&s, " ");
-	strcpy(dfu->name, st);
+	strlcpy(dfu->name, st, DFU_NAME_SIZE);
 
 	dfu->alt = alt;
 	dfu->max_buf_size = 0;

[1/5] DFU: Do not copy the entity name over the buffer size

Commit Message

Comments

Patch