diff mbox series

i2c: aspeed: Remove unused includes

Message ID 20211207141722.440213-1-thierry.reding@gmail.com
State New
Headers show
Series i2c: aspeed: Remove unused includes | expand

Commit Message

Thierry Reding Dec. 7, 2021, 2:17 p.m. UTC
From: Thierry Reding <treding@nvidia.com>

No symbols from the linux/irqchip/chained_irq.h and linux/irqdomain.h
headers are used in the driver, so they can be removed.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/i2c/busses/i2c-aspeed.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Joel Stanley Dec. 13, 2021, 11:12 p.m. UTC | #1
On Mon, 13 Dec 2021 at 22:22, Thierry Reding <thierry.reding@gmail.com> wrote:
>
> From: Thierry Reding <treding@nvidia.com>
>
> No symbols from the linux/irqchip/chained_irq.h and linux/irqdomain.h
> headers are used in the driver, so they can be removed.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Agreed, it looks like these were added in the initial commit and never used.

Reviewed-by: Joel Stanley <joel@jms.id.au>

> ---
>  drivers/i2c/busses/i2c-aspeed.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
> index 67e8b97c0c95..771e53d3d197 100644
> --- a/drivers/i2c/busses/i2c-aspeed.c
> +++ b/drivers/i2c/busses/i2c-aspeed.c
> @@ -16,8 +16,6 @@
>  #include <linux/interrupt.h>
>  #include <linux/io.h>
>  #include <linux/irq.h>
> -#include <linux/irqchip/chained_irq.h>
> -#include <linux/irqdomain.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/of_address.h>
> --
> 2.33.1
>
Wolfram Sang Dec. 16, 2021, 9:27 p.m. UTC | #2
On Tue, Dec 07, 2021 at 03:17:22PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> No symbols from the linux/irqchip/chained_irq.h and linux/irqdomain.h
> headers are used in the driver, so they can be removed.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index 67e8b97c0c95..771e53d3d197 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -16,8 +16,6 @@ 
 #include <linux/interrupt.h>
 #include <linux/io.h>
 #include <linux/irq.h>
-#include <linux/irqchip/chained_irq.h>
-#include <linux/irqdomain.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/of_address.h>