| Message ID | 20211211215120.70966-1-david@ixit.cz |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: dt-bindings: add missing pins | expand |
On Sat, Dec 11, 2021 at 10:51:19PM +0100, David Heidelberg wrote: > Add pins missing in documentation, but present in the hardware. > Fixes: 0e826e867264 ("ASoC: add RT5677 CODEC driver") Please don't just add nonsense fixes tags for the sake of it, this just creates noise and gets in the way of people trying to use the tags to work out if thy need fixes. The commit you're mentioning doesn't even contain any changes to the binding document. > @@ -54,9 +54,21 @@ Pins on the device (for linking into audio routes): > * DMIC2 > * DMIC3 > * DMIC4 > + * DMIC L1 > + * DMIC L2 > + * DMIC L3 > + * DMIC L4 > + * DMIC R1 > + * DMIC R2 > + * DMIC R3 > + * DMIC R4 These clearly aren't pins you're adding, digital microphones use PDM and carry a stereo pair on a single physical pin (which is what should be and already is in the bindings). This is adding an extra set of pins to the binding duplicating the existing ones. > * LOUT1 > * LOUT2 > * LOUT3 > + * PDM1L > + * PDM1R > + * PDM2L > + * PDM2R I'd expect these to be just PDM1 and PDM2, assuming that that's what the pins are called in the chip datasheet.
diff --git a/Documentation/devicetree/bindings/sound/rt5677.txt b/Documentation/devicetree/bindings/sound/rt5677.txt index da2430099181..74b6359b802d 100644 --- a/Documentation/devicetree/bindings/sound/rt5677.txt +++ b/Documentation/devicetree/bindings/sound/rt5677.txt @@ -54,9 +54,21 @@ Pins on the device (for linking into audio routes): * DMIC2 * DMIC3 * DMIC4 + * DMIC L1 + * DMIC L2 + * DMIC L3 + * DMIC L4 + * DMIC R1 + * DMIC R2 + * DMIC R3 + * DMIC R4 * LOUT1 * LOUT2 * LOUT3 + * PDM1L + * PDM1R + * PDM2L + * PDM2R Example:
Add pins missing in documentation, but present in the hardware. Fixes: 0e826e867264 ("ASoC: add RT5677 CODEC driver") Signed-off-by: David Heidelberg <david@ixit.cz> --- Documentation/devicetree/bindings/sound/rt5677.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+)