mbox series

[GIT,PULL,FOR,v5.17] zoran: merge into one module, many fixes

Message ID 73e71dca-fc28-6bb8-09b0-dcdd0f4974cf@xs4all.nl
State New
Headers show
Series [GIT,PULL,FOR,v5.17] zoran: merge into one module, many fixes | expand

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.17i

Message

Hans Verkuil Dec. 17, 2021, 1:21 p.m. UTC
Hi Corentin,

This is a great improvement over v3: all issues I saw before are now resolved,
and it passed the compliance tests with flying colors.

Thank you for your work on this!

While the PR is for 5.17, there is a good chance that it will slip to 5.18
due to vacation.

Regards,

	Hans

The following changes since commit 3a956f0b123c1c2b165314a3173755aa3404036c:

  Merge tag 'platform-drivers-x86-int3472-1' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86 into media_tree (2021-12-16 20:54:02 +0100)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.17i

for you to fetch changes up to 3461867e58209ef84c3e4c17a18913da5f6126ae:

  staging: media: zoran: drop read/write support (2021-12-17 13:50:43 +0100)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Corentin Labbe (14):
      staging: media: zoran: move module parameter checks to zoran_probe
      staging: media: zoran: use module_pci_driver
      staging: media: zoran: rename debug module parameter
      staging: media: zoran: add debugfs
      staging: media: zoran: videocode: remove procfs
      staging: media: zoran: merge all modules
      staging: media: zoran: remove vidmem
      staging: media: zoran: move videodev alloc
      staging: media: zoran: move config select on primary kconfig
      staging: media: zoran: introduce zoran_i2c_init
      staging: media: zoran: fix usage of vb2_dma_contig_set_max_seg_size
      staging: media: zoran: clean unused code
      staging: media: zoran: fix counting buffer in reserve
      staging: media: zoran: calculate the right buffer number for zoran_reap_stat_com

Hans Verkuil (4):
      staging: media: zoran: fix various V4L2 compliance errors
      staging: media: zoran: fix TRY_FMT handling
      staging: media: zoran: drop kernel log spam
      staging: media: zoran: drop read/write support

 drivers/staging/media/zoran/Kconfig        |  38 ++++----
 drivers/staging/media/zoran/Makefile       |   8 +-
 drivers/staging/media/zoran/videocodec.c   |  68 ++-----------
 drivers/staging/media/zoran/videocodec.h   |   4 +-
 drivers/staging/media/zoran/zoran.h        |  18 +---
 drivers/staging/media/zoran/zoran_card.c   | 398 ++++++++++++++++++++++++++++++++++++++++++++++++----------------------------
 drivers/staging/media/zoran/zoran_device.c |  15 ++-
 drivers/staging/media/zoran/zoran_device.h |   2 -
 drivers/staging/media/zoran/zoran_driver.c |  56 +++++------
 drivers/staging/media/zoran/zr36016.c      |  25 ++---
 drivers/staging/media/zoran/zr36016.h      |   2 +
 drivers/staging/media/zoran/zr36050.c      |  24 ++---
 drivers/staging/media/zoran/zr36050.h      |   2 +
 drivers/staging/media/zoran/zr36060.c      |  23 ++---
 drivers/staging/media/zoran/zr36060.h      |   2 +
 15 files changed, 349 insertions(+), 336 deletions(-)

Comments

Jenkins Dec. 17, 2021, 1:59 p.m. UTC | #1
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/73e71dca-fc28-6bb8-09b0-dcdd0f4974cf@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/166186/
Build time: 00:25:10
Link: https://lore.kernel.org/linux-media/73e71dca-fc28-6bb8-09b0-dcdd0f4974cf@xs4all.nl

gpg: Signature made Fri 17 Dec 2021 01:17:50 PM UTC
gpg:                using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 052C DE7B C215 053B 689F  1BCA BD2D 6148 6614 3B4C
     Subkey fingerprint: AAA7 FFBA 4D2D 77EF 4CAE  A142 1326 E0CD 23AB DCE5

Summary: got 5/18 patches with issues, being 5 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-staging-media-zoran-move-module-parameter-checks-to-.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples

    allyesconfig: return code #0:
	../drivers/media/rc/meson-ir-tx.c:22: warning: expecting prototype for meson(). Prototype was for DEVICE_NAME() instead
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1981 vivid_create_instance() parse error: turning off implications after 60 seconds
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	SPARSE:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
	../drivers/media/i2c/ov8865.c: ../drivers/media/i2c/ov8865.c:2843 ov8865_get_selection() warn: inconsistent indenting
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2625 dvb_register() parse error: turning off implications after 60 seconds
	../drivers/media/platform/qcom/venus/helpers.c: ../drivers/media/platform/qcom/venus/helpers.c:658 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 654)
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2889 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

patches/0006-staging-media-zoran-merge-all-modules.patch:

    allyesconfig: return code #512:
	../drivers/staging/media/zoran/zoran_card.c:1412:1: error: label ‘zr_unreg_videocodec’ defined but not used [-Werror=unused-label]
	cc1: all warnings being treated as errors
	make[5]: *** [../scripts/Makefile.build:287: drivers/staging/media/zoran/zoran_card.o] Error 1
	make[5]: *** Waiting for unfinished jobs....
	make[4]: *** [../scripts/Makefile.build:549: drivers/staging/media/zoran] Error 2
	make[3]: *** [../scripts/Makefile.build:549: drivers/staging/media] Error 2
	make[2]: *** [../scripts/Makefile.build:549: drivers/staging] Error 2
	make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1846: drivers] Error 2
	make: *** [Makefile:219: __sub-make] Error 2

    allmodconfig: return code #512:
	../drivers/staging/media/zoran/zoran_card.c:1412:1: error: label ‘zr_unreg_videocodec’ defined but not used [-Werror=unused-label]
	cc1: all warnings being treated as errors
	make[5]: *** [../scripts/Makefile.build:287: drivers/staging/media/zoran/zoran_card.o] Error 1
	make[5]: *** Waiting for unfinished jobs....
	make[4]: *** [../scripts/Makefile.build:549: drivers/staging/media/zoran] Error 2
	make[3]: *** [../scripts/Makefile.build:549: drivers/staging/media] Error 2
	make[2]: *** [../scripts/Makefile.build:549: drivers/staging] Error 2
	make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1846: drivers] Error 2
	make: *** [Makefile:219: __sub-make] Error 2

patches/0007-staging-media-zoran-remove-vidmem.patch:

    allyesconfig: return code #512:
	../drivers/staging/media/zoran/zoran_card.c:1397:1: error: label ‘zr_unreg_videocodec’ defined but not used [-Werror=unused-label]
	cc1: all warnings being treated as errors
	make[5]: *** [../scripts/Makefile.build:287: drivers/staging/media/zoran/zoran_card.o] Error 1
	make[4]: *** [../scripts/Makefile.build:549: drivers/staging/media/zoran] Error 2
	make[3]: *** [../scripts/Makefile.build:549: drivers/staging/media] Error 2
	make[2]: *** [../scripts/Makefile.build:549: drivers/staging] Error 2
	make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1846: drivers] Error 2
	make: *** [Makefile:219: __sub-make] Error 2

    allmodconfig: return code #512:
	../drivers/staging/media/zoran/zoran_card.c:1397:1: error: label ‘zr_unreg_videocodec’ defined but not used [-Werror=unused-label]
	cc1: all warnings being treated as errors
	make[5]: *** [../scripts/Makefile.build:287: drivers/staging/media/zoran/zoran_card.o] Error 1
	make[4]: *** [../scripts/Makefile.build:549: drivers/staging/media/zoran] Error 2
	make[3]: *** [../scripts/Makefile.build:549: drivers/staging/media] Error 2
	make[2]: *** [../scripts/Makefile.build:549: drivers/staging] Error 2
	make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1846: drivers] Error 2
	make: *** [Makefile:219: __sub-make] Error 2

patches/0008-staging-media-zoran-move-videodev-alloc.patch:

    allyesconfig: return code #512:
	../drivers/staging/media/zoran/zoran_card.c:1417:1: error: label ‘zr_unreg_videocodec’ defined but not used [-Werror=unused-label]
	cc1: all warnings being treated as errors
	make[5]: *** [../scripts/Makefile.build:287: drivers/staging/media/zoran/zoran_card.o] Error 1
	make[5]: *** Waiting for unfinished jobs....
	make[4]: *** [../scripts/Makefile.build:549: drivers/staging/media/zoran] Error 2
	make[3]: *** [../scripts/Makefile.build:549: drivers/staging/media] Error 2
	make[2]: *** [../scripts/Makefile.build:549: drivers/staging] Error 2
	make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1846: drivers] Error 2
	make: *** [Makefile:219: __sub-make] Error 2

    allmodconfig: return code #512:
	../drivers/staging/media/zoran/zoran_card.c:1417:1: error: label ‘zr_unreg_videocodec’ defined but not used [-Werror=unused-label]
	cc1: all warnings being treated as errors
	make[5]: *** [../scripts/Makefile.build:287: drivers/staging/media/zoran/zoran_card.o] Error 1
	make[5]: *** Waiting for unfinished jobs....
	make[4]: *** [../scripts/Makefile.build:549: drivers/staging/media/zoran] Error 2
	make[3]: *** [../scripts/Makefile.build:549: drivers/staging/media] Error 2
	make[2]: *** [../scripts/Makefile.build:549: drivers/staging] Error 2
	make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1846: drivers] Error 2
	make: *** [Makefile:219: __sub-make] Error 2

patches/0009-staging-media-zoran-move-config-select-on-primary-kc.patch:

    allyesconfig: return code #512:
	../drivers/staging/media/zoran/zoran_card.c:1417:1: error: label ‘zr_unreg_videocodec’ defined but not used [-Werror=unused-label]
	cc1: all warnings being treated as errors
	make[5]: *** [../scripts/Makefile.build:287: drivers/staging/media/zoran/zoran_card.o] Error 1
	make[4]: *** [../scripts/Makefile.build:549: drivers/staging/media/zoran] Error 2
	make[3]: *** [../scripts/Makefile.build:549: drivers/staging/media] Error 2
	make[2]: *** [../scripts/Makefile.build:549: drivers/staging] Error 2
	make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1846: drivers] Error 2
	make: *** [Makefile:219: __sub-make] Error 2

    allmodconfig: return code #512:
	../drivers/staging/media/zoran/zoran_card.c:1417:1: error: label ‘zr_unreg_videocodec’ defined but not used [-Werror=unused-label]
	cc1: all warnings being treated as errors
	make[5]: *** [../scripts/Makefile.build:287: drivers/staging/media/zoran/zoran_card.o] Error 1
	make[4]: *** [../scripts/Makefile.build:549: drivers/staging/media/zoran] Error 2
	make[3]: *** [../scripts/Makefile.build:549: drivers/staging/media] Error 2
	make[2]: *** [../scripts/Makefile.build:549: drivers/staging] Error 2
	make[1]: *** [/var/lib/jenkins/workspace/patchwork/Makefile:1846: drivers] Error 2
	make: *** [Makefile:219: __sub-make] Error 2


Error #512 when building PDF docs