[12/23] wilc1000: refactor wilc_wlan_cfg_commit() a bit

Message ID	20211218235404.3963475-13-davidm@egauge.net
State	Superseded
Headers	show Return-Path: <linux-wireless-owner@kernel.org> From: David Mosberger-Tang <davidm@egauge.net> Subject: [PATCH 12/23] wilc1000: refactor wilc_wlan_cfg_commit() a bit Date: Sat, 18 Dec 2021 23:54:17 +0000 (UTC) Message-Id: <20211218235404.3963475-13-davidm@egauge.net> In-Reply-To: <20211218235404.3963475-1-davidm@egauge.net> References: <20211218235404.3963475-1-davidm@egauge.net> MIME-Version: 1.0 To: Ajay Singh <ajay.kathat@microchip.com> Cc: Claudiu Beznea <claudiu.beznea@microchip.com>, Kalle Valo <kvalo@codeaurora.org>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Mosberger-Tang <davidm@egauge.net> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Precedence: bulk
Series	wilc1000: rework tx path to use sk_buffs throughout \| expand [00/23] wilc1000: rework tx path to use sk_buffs throughout [04/23] wilc1000: factor common code in wilc_wlan_cfg_set() and wilc_wlan_cfg_get() [05/23] wilc1000: add wilc_wlan_tx_packet_done() function [01/23] wilc1000: don't hold txq_spinlock while initializing AC queue limits [03/23] wilc1000: move receive-queue stats from txq to wilc structure [06/23] wilc1000: move tx packet drop code into its own function [02/23] wilc1000: switch txq_event from completion to waitqueue [12/23] wilc1000: refactor wilc_wlan_cfg_commit() a bit [08/23] wilc1000: fix management packet type inconsistency [22/23] wilc1000: minor syntax cleanup [20/23] wilc1000: eliminate "max_size_over" variable in fill_vmm_table [21/23] wilc1000: declare read-only ac_preserve_ratio as static and const [17/23] wilc1000: remove no longer used "vif" argument from init_txq_entry() [10/23] wilc1000: factor initialization of tx queue-specific packet fields [13/23] wilc1000: sanitize config packet sequence number management a bit [09/23] wilc1000: prepare wilc_wlan_tx_packet_done() for sk_buff changes [16/23] wilc1000: switch tx queue to normal sk_buff entries [19/23] wilc1000: don't tell the chip to go to sleep while copying tx packets [18/23] wilc1000: split huge tx handler into subfunctions [14/23] wilc1000: if there is no tx packet, don't increment packets-sent counter [15/23] wilc1000: Add struct wilc_skb_tx_cb as an alias of struct txq_entry_t [23/23] wilc1000: introduce symbolic names for two tx-related control bits [07/23] wilc1000: increment tx_dropped stat counter on tx packet drop [11/23] wilc1000: convert tqx_entries from "int" to "atomic_t"

Message ID

20211218235404.3963475-13-davidm@egauge.net

State

Superseded

Headers

From: David Mosberger-Tang <davidm@egauge.net>
Subject: [PATCH 12/23] wilc1000: refactor wilc_wlan_cfg_commit() a bit
Date: Sat, 18 Dec 2021 23:54:17 +0000 (UTC)
Message-Id: <20211218235404.3963475-13-davidm@egauge.net>
In-Reply-To: <20211218235404.3963475-1-davidm@egauge.net>
References: <20211218235404.3963475-1-davidm@egauge.net>
MIME-Version: 1.0
To: Ajay Singh <ajay.kathat@microchip.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        David Mosberger-Tang <davidm@egauge.net>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii
Precedence: bulk

Series

wilc1000: rework tx path to use sk_buffs throughout | expand

Commit Message

David Mosberger-Tang Dec. 18, 2021, 11:54 p.m. UTC

This cleanup makes the switch to sk_buff queues easier.  There is no
functional change.

Signed-off-by: David Mosberger-Tang <davidm@egauge.net>
---
 drivers/net/wireless/microchip/wilc1000/wlan.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c
index 8435e1abdd515..8cd2ede8d2775 100644
--- a/drivers/net/wireless/microchip/wilc1000/wlan.c
+++ b/drivers/net/wireless/microchip/wilc1000/wlan.c
@@ -1271,15 +1271,13 @@  static int wilc_wlan_cfg_commit(struct wilc_vif *vif, int type,
 	struct wilc *wilc = vif->wilc;
 	struct wilc_cfg_frame *cfg = &wilc->cfg_frame;
 	int t_len = wilc->cfg_frame_offset + sizeof(struct wilc_cfg_cmd_hdr);
+	struct wilc_cfg_cmd_hdr *hdr;
 
-	if (type == WILC_CFG_SET)
-		cfg->hdr.cmd_type = 'W';
-	else
-		cfg->hdr.cmd_type = 'Q';
-
-	cfg->hdr.seq_no = wilc->cfg_seq_no % 256;
-	cfg->hdr.total_len = cpu_to_le16(t_len);
-	cfg->hdr.driver_handler = cpu_to_le32(drv_handler);
+	hdr = &cfg->hdr;
+	hdr->cmd_type = (type == WILC_CFG_SET) ? 'W' : 'Q';
+	hdr->seq_no = wilc->cfg_seq_no % 256;
+	hdr->total_len = cpu_to_le16(t_len);
+	hdr->driver_handler = cpu_to_le32(drv_handler);
 	wilc->cfg_seq_no = cfg->hdr.seq_no;
 
 	if (!wilc_wlan_txq_add_cfg_pkt(vif, (u8 *)&cfg->hdr, t_len))

[12/23] wilc1000: refactor wilc_wlan_cfg_commit() a bit

Commit Message

Patch