| Message ID | 20211222090159.916428-1-hch@lst.de |
|---|---|
| State | New |
| Headers | show |
| Series | sr: don't use GFP_DMA in get_capabilities | expand |
On 12/22/21 1:01 AM, Christoph Hellwig wrote: > The allocated buffer is used as a command payload, for which the block > layer and/or DMA API do the proper bounce buffering if needed. > > Reported-by: Baoquan He <bhe@redhat.com> > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/scsi/sr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c > index 14c122839c409..f925b1f1f9ada 100644 > --- a/drivers/scsi/sr.c > +++ b/drivers/scsi/sr.c > @@ -855,7 +855,7 @@ static void get_capabilities(struct scsi_cd *cd) > > > /* allocate transfer buffer */ > - buffer = kmalloc(512, GFP_KERNEL | GFP_DMA); > + buffer = kmalloc(512, GFP_KERNEL); > if (!buffer) { > sr_printk(KERN_ERR, cd, "out of memory.\n"); A separate trivial cleanup is the unnecessary memory allocation failure message here since the mm layer will already report such things. -Tyrel > return; >
diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c index 14c122839c409..f925b1f1f9ada 100644 --- a/drivers/scsi/sr.c +++ b/drivers/scsi/sr.c @@ -855,7 +855,7 @@ static void get_capabilities(struct scsi_cd *cd) /* allocate transfer buffer */ - buffer = kmalloc(512, GFP_KERNEL | GFP_DMA); + buffer = kmalloc(512, GFP_KERNEL); if (!buffer) { sr_printk(KERN_ERR, cd, "out of memory.\n"); return;
The allocated buffer is used as a command payload, for which the block layer and/or DMA API do the proper bounce buffering if needed. Reported-by: Baoquan He <bhe@redhat.com> Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/scsi/sr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)