| Message ID | 20211230102110.3861-4-yu.tu@amlogic.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | the UART driver compatible with the Amlogic Meson | expand |
Hello, as Greg already mentioned the $subject line is very long. On Thu, Dec 30, 2021 at 11:21 AM Yu Tu <yu.tu@amlogic.com> wrote: > Deprecated, don't use anymore because compatible = amlogic,meson-gx-uart > don't differentiate between GXBB and GXL which have different > revisions of the UART IP. So it's split into GXBB and GXL. actually it's split into GXBB, GXL and G12A [...] > - - amlogic,meson-gx-uart > + - amlogic,meson-gxbb-uart > + - amlogic,meson-gxl-uart > + - amlogic,meson-g12a-uart > + - amlogic,meson-s4-uart In addition to Greg's comment I suggest splitting this into two patches: - one where the "amlogic,meson-gx-uart" compatible is marked as deprecated (Documentation/devicetree/bindings/power/supply/bq27xxx.yaml has an example for deprecated entries) and GXBB, GXL and G12A compatible strings are added instead - another one where the new S4 compatible string is added The idea here is to have "one logical change per patch". Deprecating and replacing "amlogic,meson-gx-uart" is one logical change. Adding a new compatible string is another logical change. I am hoping that this will also make it easier to find a shorter $subject line (which according to the patch submission guide [0] should be 70-75 characters: "the summary must be no more than 70-75 characters") Best regards, Martin [0] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#the-canonical-patch-format
Hi Greg, Thank you for your reply. On 2021/12/30 20:28, Greg Kroah-Hartman wrote: > [ EXTERNAL EMAIL ] > > On Thu, Dec 30, 2021 at 06:21:07PM +0800, Yu Tu wrote: >> Deprecated, don't use anymore because compatible = amlogic,meson-gx-uart >> don't differentiate between GXBB and GXL which have different >> revisions of the UART IP. So it's split into GXBB and GXL. >> >> Signed-off-by: Yu Tu <yu.tu@amlogic.com> >> --- >> .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) > > Again, your subject line is way too long. > I will correct. > thanks, > > greg k-h >
On 2021/12/31 6:34, Martin Blumenstingl wrote: > [ EXTERNAL EMAIL ] > > Hello, > > as Greg already mentioned the $subject line is very long. > > On Thu, Dec 30, 2021 at 11:21 AM Yu Tu <yu.tu@amlogic.com> wrote: >> Deprecated, don't use anymore because compatible = amlogic,meson-gx-uart >> don't differentiate between GXBB and GXL which have different >> revisions of the UART IP. So it's split into GXBB and GXL. > actually it's split into GXBB, GXL and G12A > > [...] >> - - amlogic,meson-gx-uart >> + - amlogic,meson-gxbb-uart >> + - amlogic,meson-gxl-uart >> + - amlogic,meson-g12a-uart >> + - amlogic,meson-s4-uart > In addition to Greg's comment I suggest splitting this into two patches: > - one where the "amlogic,meson-gx-uart" compatible is marked as > deprecated (Documentation/devicetree/bindings/power/supply/bq27xxx.yaml > has an example for deprecated entries) and GXBB, GXL and G12A > compatible strings are added instead > - another one where the new S4 compatible string is added > > The idea here is to have "one logical change per patch". > Deprecating and replacing "amlogic,meson-gx-uart" is one logical change. > Adding a new compatible string is another logical change. > I am hoping that this will also make it easier to find a shorter > $subject line (which according to the patch submission guide [0] > should be 70-75 characters: "the summary must be no more than 70-75 > characters") > I will split the two patches in the next version.One was deprecating and replacing "AmLogic, Meson-GX-Uart" and the other added S4 compatible. > > Best regards, > Martin > > > [0] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#the-canonical-patch-format >
diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml index 75ebc9952a99..b03040a83a9f 100644 --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml @@ -28,14 +28,20 @@ properties: - amlogic,meson6-uart - amlogic,meson8-uart - amlogic,meson8b-uart - - amlogic,meson-gx-uart + - amlogic,meson-gxbb-uart + - amlogic,meson-gxl-uart + - amlogic,meson-g12a-uart + - amlogic,meson-s4-uart - const: amlogic,meson-ao-uart - description: Everything-Else power domain UART controller enum: - amlogic,meson6-uart - amlogic,meson8-uart - amlogic,meson8b-uart - - amlogic,meson-gx-uart + - amlogic,meson-gxbb-uart + - amlogic,meson-gxl-uart + - amlogic,meson-g12a-uart + - amlogic,meson-s4-uart reg: maxItems: 1
Deprecated, don't use anymore because compatible = amlogic,meson-gx-uart don't differentiate between GXBB and GXL which have different revisions of the UART IP. So it's split into GXBB and GXL. Signed-off-by: Yu Tu <yu.tu@amlogic.com> --- .../devicetree/bindings/serial/amlogic,meson-uart.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)